Subject: Re: [PATCH 1/2] port ndfc driver to of platform

From: Arnd Bergmann <[email-masked]>
Date: Fri, 15 Aug 2008 09:27:41 +0200

On Friday 15 August 2008, Sean MacLennan wrote:
> Port the ndfc driver to an OF platform driver.
> 
> Signed-off-by: Sean MacLennan <[email-masked]>

Acked-by: Arnd Bergmann <[email-masked]>

Looks great, but I just noticed one more detail:

> +static const struct of_device_id ndfc_match[] = {
> +	{ .compatible = "amcc,ndfc", },
> +	{}
>  };
>  

You should add

MODULE_DEVICE_TABLE(of, &ndfc_match);

to enable module auto-loading.

	Arnd <><