From: Arnd Bergmann <arnd@arndb•de>
To: linuxppc-embedded@ozlabs•org
Cc: Wolfram Sang <w.sang@pengutronix•de>
Subject: Re: [PATCH] MPC52XX: Don't touch pipelining for MPC5200B
Date: Mon, 18 Aug 2008 12:49:36 +0200 [thread overview]
Message-ID: <200808181249.37220.arnd@arndb.de> (raw)
In-Reply-To: <20080818093132.GA4282@pengutronix.de>
On Monday 18 August 2008, Wolfram Sang wrote:
> MPC5200 needs to have pipelining disabled for ATA to work. MPC5200B does =
not.
> So, for the latter, don't touch the original setting from the bootloader.
> +#if defined(CONFIG_PPC_MPC5200_BUGFIX)
> =A0=A0=A0=A0=A0=A0=A0=A0/* Disable XLB pipelining
Please make this a run-time conditional instead of compile-time.
Your current patch is still broken if you want to have a common
kernel for MPC5200 and MPC5200B.
Arnd <><
next prev parent reply other threads:[~2008-08-18 10:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-18 9:31 [PATCH] MPC52XX: Don't touch pipelining for MPC5200B Wolfram Sang
2008-08-18 10:49 ` Arnd Bergmann [this message]
2008-08-18 14:18 ` [PATCH V2] " Wolfram Sang
2008-08-18 15:57 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808181249.37220.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=linuxppc-embedded@ozlabs$(echo .)org \
--cc=w.sang@pengutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox