Subject: Re: [PATCH] ppc4xx_pci: necessary fixes for 4GB RAM size

From: Stefan Roese <[email-masked]>
Date: Thu, 28 Aug 2008 16:18:31 +0200

On Thursday 28 August 2008, Josh Boyer wrote:
> > 1. total_memory should be phys_addr_t not unsigned long
> > 2. is_power_of_2() works with u32 so I just inlined (size & (size-1)) !=
> > 0 instead.
> > Also this patch fixes default initialization: res->end should be
> > 0x7fffffff not 0x80000000.
> >
> > Signed-off-by: Ilya Yanok <[email-masked]>
>
> Ben, any comments here?  Looks right to me.

Looks good to me too. So:

Acked-by: Stefan Roese <[email-masked]>

Best regards,
Stefan