Subject: Re: [RFC] adding hwmon support to sequoia device tree

From: Stefan Roese <[email-masked]>
Date: Thu, 4 Sep 2008 14:50:16 +0200

On Thursday 04 September 2008, Josh Boyer wrote:
> >Do we want to add this to the sequoia dts file? If this is how it should
> > be done, I will commit a proper patch.
>
> See comments below.  Out of curiosity, do you have a working driver and
> setup with this?

Sure, it did hit mainline with 2.6.27:

drivers/hwmon/ad7414.c

> >diff --git a/arch/powerpc/boot/dts/sequoia.dts
> > b/arch/powerpc/boot/dts/sequoia.dts index 72d15f0..82fdfdf 100644
> >--- a/arch/powerpc/boot/dts/sequoia.dts
> >+++ b/arch/powerpc/boot/dts/sequoia.dts
> >@@ -246,13 +246,23 @@
> >                        };
> >
> >                        IIC0: i2c@ef600700 {
> >+                               #address-cells = <1>;
> >+                               #size-cells = <0>;
> >                                compatible = "ibm,iic-440epx", "ibm,iic";
> >                                reg = <0xef600700 0x00000014>;
> >                                interrupt-parent = <&UIC0>;
> >                                interrupts = <0x2 0x4>;
> >+
> >+                               hwmon@48 {
> >+                                       device_type = "hwmon";
>
> We don't need device_type.  Particularly not a new one like this.
>
> >+                                       compatible = "analog,ad7414";
>
> Perhaps 'compatible = "analog,ad7417", "amcc,hwmon-440epx";'

I don't think we need any amcc and/or 440epx here. Its a common chip from 
Analog.

Best regards,
Stefan