Subject: Re: [FIX] fs_enet: Using mii-bitbang as module

From: Vitaly Bordug <[email-masked]>
Date: Thu, 4 Sep 2008 22:40:18 +0400

В Thu, 04 Sep 2008 08:01:38 +0200
Heiko Schocher <[email-masked]> пишет:

> Hello Vitaly,
> 
> I tried to use the mii-bitbang driver
> (drivers/net/fs_enet/mii-bitbang.c) as a module and got the following
> error, when inserting it with insmod:
> 
> ~ # insmod fs_enet
> eth0: fs_enet: a6:07:11:7f:de:26
> ~ # insmod mii-bitbang
> mii_bitbang: module license 'unspecified' taints kernel.
> mii_bitbang: Unknown symbol of_address_to_resource
> mii_bitbang: Unknown symbol of_irq_to_resource
> insmod: cannot insert
> '/lib/modules/2.6.27-rc5-01144-g967b424-dirty/kernel/drivers/net/fs_enet/mii-bitbang.ko':
> Unknown symbol in module (-1): No such file or directory ~ #
> 
> Following patch solves this. Maybe you add the other MODULE_ macros
> too?
Maybe _DESCRIPTION()... I'll combine my part with yours and will send it
to netdev.

Thanks,
-Vitaly
> 
> Signed-off-by: Heiko Schocher <[email-masked]>
> ---
>  drivers/net/fs_enet/mii-bitbang.c                  |    2 +
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/fs_enet/mii-bitbang.c
> b/drivers/net/fs_enet/mii-bitbang.c index be4b72f..863ceed 100644
> --- a/drivers/net/fs_enet/mii-bitbang.c
> +++ b/drivers/net/fs_enet/mii-bitbang.c
> @@ -26,6 +26,8 @@
> 
>  #include "fs_enet.h"
> 
> +MODULE_LICENSE("GPL");
> +
>  struct bb_info {
>  	struct mdiobb_ctrl ctrl;
>  	__be32 __iomem *dir;