Subject: Re: [PATCH] powerpc/44x: Add hwmon support to Sequoia device tree

From: Matthias Fuchs <[email-masked]>
Date: Fri, 5 Sep 2008 16:58:38 +0200

Hi,

I was inspired by some I2C RTC node (tqm5200.dts). Those nodes
are named rtc@... But to be in common I can change it. Also
the vendor is differnet in warp's dts file. adi (analog device inc.) against
"analog".

So I will update my patch to be compatible with warp.dts.

I keep your ack, Stefan.

Matthias

On Friday 05 September 2008 12:19, Stefan Roese wrote:
> > diff --git a/arch/powerpc/boot/dts/sequoia.dts
> > b/arch/powerpc/boot/dts/sequoia.dts index 72d15f0..9ba5def 100644
> > --- a/arch/powerpc/boot/dts/sequoia.dts
> > +++ b/arch/powerpc/boot/dts/sequoia.dts
> > @@ -246,13 +246,22 @@
> >  	   		};
> >
> >  			IIC0: i2c@ef600700 {
> > +				#address-cells = <1>;
> > +				#size-cells = <0>;
> >  				compatible = "ibm,iic-440epx", "ibm,iic";
> >  				reg = <0xef600700 0x00000014>;
> >  				interrupt-parent = <&UIC0>;
> >  				interrupts = <0x2 0x4>;
> > +
> > +				hwmon@48 {
> 
> Not sure if we shouldn't use
> 
>                                 ad7414@48 {
> 
> here. This is the way it is already done in warp.dts.