Subject: Re: [PATCH 1/2] OF: add fsl,mcu-mpc8349emitx to the exception list

From: Anton Vorontsov <[email-masked]>
Date: Tue, 30 Sep 2008 16:44:24 +0400

On Tue, Sep 23, 2008 at 06:12:19PM +0400, Anton Vorontsov wrote:
> of/base.c matches on the first (most specific) entries, which isn't
> quite practical but it was discussed[1] that this won't change.
> 
> The bindings specifies verbose information for the devices, but
> it doesn't fit in the I2C ID's 20 characters limit. The limit won't
> change[2], and the bindings won't change either as they're correct.
> 
> So we have to put an exception for the MPC8349E-mITX-compatible
> MCUs.
> 
> [1] http://www.mail-archive.com/[email-masked]/msg21196.html
> [2] http://www.nabble.com/-PATCH-1-2--i2c:-expand-I2C's-id.name-to-23-characters-td19577063.html
> 
> Signed-off-by: Anton Vorontsov <[email-masked]>
> ---
>  drivers/of/base.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Any issues with this or the second patch? Can we merge them?

Thanks,

> diff --git a/drivers/of/base.c b/drivers/of/base.c
> index ad8ac1a..a726464 100644
> --- a/drivers/of/base.c
> +++ b/drivers/of/base.c
> @@ -410,7 +410,7 @@ struct of_modalias_table {
>  	char *modalias;
>  };
>  static struct of_modalias_table of_modalias_table[] = {
> -	/* Empty for now; add entries as needed */
> +	{ "fsl,mcu-mpc8349emitx", "mcu-mpc8349emitx" },
>  };
>  
>  /**
> -- 
> 1.5.6.3

-- 
Anton Vorontsov
email: [email-masked]
irc://irc.freenode.net/bd2