From: Anton Vorontsov <avorontsov@ru•mvista.com>
To: Timur Tabi <timur@freescale•com>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH] powerpc: make Freescale QE support a selectable Kconfig option
Date: Fri, 3 Oct 2008 20:23:17 +0400 [thread overview]
Message-ID: <20081003162317.GA31740@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <48E643A5.9060403@freescale.com>
Otherwise user-selectable options appears at the top level.
Signed-off-by: Anton Vorontsov <avorontsov@ru•mvista.com>
---
On Fri, Oct 03, 2008 at 11:09:09AM -0500, Timur Tabi wrote:
> Anton Vorontsov wrote:
>
> > Yup. David said that platform GPIO controllers should not go into the
> > drivers/gpio/, their place is in the arch/.
>
> Then when I do "make menuconfig", why doesn't that option appear under "Platform
> support"?
Because the whole arch/powerpc/sysdev/qe_lib/Kconfig includes into
the top level Kconfig.
> This is what I see now:
>
> [*] Networking support --->
> Device Drivers --->
> File systems --->
> [*] QE GPIO support
> Library routines --->
> Kernel hacking --->
Damn, this is bad indeed (I don't use the menuconfig, never saw this).
I think arch/powerpc/sysdev/qe_lib/Kconfig inclusion should be fixed.
How about this patch? Or we can move QUICC_ENGINE into the
qe_lib/Kconfig and include it in the platform/Kconfig... either
way would work.
Thanks for noticing.
arch/powerpc/Kconfig | 2 --
arch/powerpc/platforms/Kconfig | 36 ++++++++++++++++++++++++++++++++++++
arch/powerpc/sysdev/qe_lib/Kconfig | 35 -----------------------------------
3 files changed, 36 insertions(+), 37 deletions(-)
delete mode 100644 arch/powerpc/sysdev/qe_lib/Kconfig
diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index 587da5e..dd976b6 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig
@@ -829,8 +829,6 @@ source "fs/Kconfig"
# XXX source "arch/ppc/8260_io/Kconfig"
-source "arch/powerpc/sysdev/qe_lib/Kconfig"
-
source "lib/Kconfig"
source "arch/powerpc/Kconfig.debug"
diff --git a/arch/powerpc/platforms/Kconfig b/arch/powerpc/platforms/Kconfig
index 4c900ef..da6da51 100644
--- a/arch/powerpc/platforms/Kconfig
+++ b/arch/powerpc/platforms/Kconfig
@@ -248,6 +248,42 @@ config QUICC_ENGINE
Selecting this option means that you wish to build a kernel
for a machine with a QE coprocessor.
+if QUICC_ENGINE
+
+config UCC_SLOW
+ bool
+ default y if SERIAL_QE
+ help
+ This option provides qe_lib support to UCC slow
+ protocols: UART, BISYNC, QMC
+
+config UCC_FAST
+ bool
+ default y if UCC_GETH
+ help
+ This option provides qe_lib support to UCC fast
+ protocols: HDLC, Ethernet, ATM, transparent
+
+config UCC
+ bool
+ default y if UCC_FAST || UCC_SLOW
+
+config QE_USB
+ bool
+ help
+ QE USB Host Controller support
+
+config QE_GPIO
+ bool "QE GPIO support"
+ depends on QUICC_ENGINE
+ select GENERIC_GPIO
+ select ARCH_REQUIRE_GPIOLIB
+ help
+ Say Y here if you're going to use hardware that connects to the
+ QE GPIOs.
+
+endif
+
config CPM2
bool "Enable support for the CPM2 (Communications Processor Module)"
depends on MPC85xx || 8260
diff --git a/arch/powerpc/sysdev/qe_lib/Kconfig b/arch/powerpc/sysdev/qe_lib/Kconfig
deleted file mode 100644
index 1ce5464..0000000
--- a/arch/powerpc/sysdev/qe_lib/Kconfig
+++ /dev/null
@@ -1,35 +0,0 @@
-#
-# QE Communication options
-#
-
-config UCC_SLOW
- bool
- default y if SERIAL_QE
- help
- This option provides qe_lib support to UCC slow
- protocols: UART, BISYNC, QMC
-
-config UCC_FAST
- bool
- default y if UCC_GETH
- help
- This option provides qe_lib support to UCC fast
- protocols: HDLC, Ethernet, ATM, transparent
-
-config UCC
- bool
- default y if UCC_FAST || UCC_SLOW
-
-config QE_USB
- bool
- help
- QE USB Host Controller support
-
-config QE_GPIO
- bool "QE GPIO support"
- depends on QUICC_ENGINE
- select GENERIC_GPIO
- select ARCH_REQUIRE_GPIOLIB
- help
- Say Y here if you're going to use hardware that connects to the
- QE GPIOs.
--
1.5.6.3
next prev parent reply other threads:[~2008-10-03 16:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-02 15:27 [PATCH] powerpc: make Freescale QE support a selectable Kconfig option Timur Tabi
2008-10-03 5:12 ` Kumar Gala
2008-10-03 7:04 ` Anton Vorontsov
2008-10-03 7:58 ` Kumar Gala
2008-10-03 8:48 ` Anton Vorontsov
2008-10-03 9:08 ` Anton Vorontsov
2008-10-03 15:43 ` Timur Tabi
2008-10-03 16:05 ` Anton Vorontsov
2008-10-03 16:09 ` Timur Tabi
2008-10-03 16:18 ` Kumar Gala
2008-10-03 16:23 ` Anton Vorontsov [this message]
2008-10-03 16:54 ` Timur Tabi
2008-10-03 17:48 ` Kumar Gala
2008-10-03 19:40 ` [PATCH] powerpc/QE: move QE_GPIO Kconfig symbol into the platforms/Kconfig Anton Vorontsov
2008-10-03 21:55 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081003162317.GA31740@oksana.dev.rtsoft.ru \
--to=avorontsov@ru$(echo .)mvista.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=timur@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox