Subject: [PATCH] powerpc/cell/oprofile: vma_map: fix test on overlay_tbl_offset

From: Arnd Bergmann <[email-masked]>
Date: Tue, 7 Oct 2008 10:38:33 +0200

From: Roel Kluin <[email-masked]>

Offset is unsigned and when an address isn't found in the vma map
vma_map_lookup() returns the vma physical address + 0x10000000.

vma_map_lookup used to return 0xffffffff on a failed lookup, but
a change was made to return the vma physical address + 0x10000000
There are two callers of vam_map_lookup: one of them correctly 
deals with this new return value, but the other (below) did not.  

Signed-off-by: Roel Kluin <[email-masked]>
Acked-by: Maynard Johnson <[email-masked]>
Signed-off-by: Arnd Bergmann <[email-masked]>
Cc: [email-masked]
Cc: Carl Love <[email-masked]>

--- a/arch/powerpc/oprofile/cell/vma_map.c
+++ b/arch/powerpc/oprofile/cell/vma_map.c
@@ -229,7 +229,7 @@ struct vma_to_fileoffset_map *create_vma_map(const struct spu *aSpu,
 	 */
 	overlay_tbl_offset = vma_map_lookup(map, ovly_table_sym,
 					    aSpu, &grd_val);
-	if (overlay_tbl_offset < 0) {
+	if (overlay_tbl_offset > 0x10000000) {
 		printk(KERN_ERR "SPU_PROF: "
 		       "%s, line %d: Error finding SPU overlay table\n",
 		       __func__, __LINE__);