From: Simon Horman <horms@verge•net.au>
To: Sebastian Andrzej Siewior <sebastian@breakpoint•cc>
Cc: linuxppc-dev@ozlabs•org,
Sebastian Siewior <bigeasy@linutronix•de>,
kexec@lists•infradead.org
Subject: Re: [PATCH] powerpc: dtb and purgatory support for ppc32
Date: Wed, 15 Oct 2008 14:37:36 +1100 [thread overview]
Message-ID: <20081015033735.GG27243@verge.net.au> (raw)
In-Reply-To: <20081012133955.GA7536@Chamillionaire.breakpoint.cc>
On Sun, Oct 12, 2008 at 03:39:55PM +0200, Sebastian Andrzej Siewior wrote:
> * Simon Horman | 2008-10-08 14:03:26 [+1100]:
>
> >> +#ifdef WITH_GAMECUBE
> >> +static int go_purgatory = 0;
> >> +#else
> >> +static int go_purgatory = 1;
> >> +#endif
> >
> >Can you just use WITH_GAMECUBE inside elf_ppc_load() and remove
> >the need for go_purgatory, or do you plan to make go_purgatory
> >switchable at run-time at some point in the future?
> For the first shot I would prefer to use WITH_GAMECUBE inside of
> elf_ppc_load(). In longterm I don't see any reason why GameCube can't
> use the purgatory code like the other archs and get the memory maps from
> the device tree. However I'm not sure if GameCube still runs on a recent
> kernel: now that arc/ppc isn't available anymore GameCube has to pass a
> dtb somehow and this isn't the case. So therefore I would like the keep
> #ifdef and the exisiting behavior until someone clears this up.
Ok, in this case I would like to request that you remove
go_purgatory (for now) and just use #ifdef WITH_GAMECUBE instead.
I think that it will make things cleaner (for now).
--
Simon Horman
VA Linux Systems Japan K.K., Sydney, Australia Satellite Office
H: www.vergenet.net/~horms/ W: www.valinux.co.jp/en
prev parent reply other threads:[~2008-10-15 3:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-01 21:20 [RFC] kexec support on Book-e, ppc32 Sebastian Andrzej Siewior
2008-10-01 21:20 ` [RFC] powerpc: add kexec support on Book-E Sebastian Andrzej Siewior
2008-10-10 3:53 ` Benjamin Herrenschmidt
2008-10-12 13:55 ` Sebastian Andrzej Siewior
2008-10-01 21:20 ` [RFC] powerpc: enable kexec support on mpc8544ds Sebastian Andrzej Siewior
2008-10-01 21:20 ` [PATCH] powerpc: dtb and purgatory support for ppc32 Sebastian Andrzej Siewior
2008-10-02 3:54 ` Kumar Gala
2008-10-02 7:50 ` Sebastian Siewior
2008-10-02 10:05 ` Simon Horman
2008-10-03 5:44 ` Mohan Kumar M
2008-10-02 12:52 ` Kumar Gala
2008-10-02 13:03 ` Sebastian Andrzej Siewior
2008-10-08 3:03 ` Simon Horman
2008-10-12 13:39 ` Sebastian Andrzej Siewior
2008-10-15 3:37 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081015033735.GG27243@verge.net.au \
--to=horms@verge$(echo .)net.au \
--cc=bigeasy@linutronix$(echo .)de \
--cc=kexec@lists$(echo .)infradead.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=sebastian@breakpoint$(echo .)cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox