Subject: Re: [PATCH 5/7] of/gpio: implement of_dev_gpiochip_{add, remove} calls

From: David Brownell <[email-masked]>
Date: Fri, 17 Oct 2008 13:25:01 -0700

On Thursday 16 October 2008, Anton Vorontsov wrote:
> +       if (of_gc->chip)
> +               return of_gc->chip;
> +       return &of_gc->gc;

presumably there's a reason not to

	of_gc->chip = &of_gc->gc;

when this gets set up, so this can always be a simple

	return of_gc->chip;

(and inlined)?  Needlessly complex...