Subject: Re: [PATCH 1/2] powerpc/83xx: add DS1339 RTC support for MPC8349E-mITX boards

From: Anton Vorontsov <[email-masked]>
Date: Tue, 21 Oct 2008 22:41:09 +0400

On Tue, Oct 21, 2008 at 01:23:44PM -0500, Scott Wood wrote:
> On Fri, Oct 17, 2008 at 10:56:59PM +0400, Anton Vorontsov wrote:
> > diff --git a/arch/powerpc/boot/dts/mpc8349emitx.dts b/arch/powerpc/boot/dts/mpc8349emitx.dts
> > index 5cedf37..7fc5414 100644
> > --- a/arch/powerpc/boot/dts/mpc8349emitx.dts
> > +++ b/arch/powerpc/boot/dts/mpc8349emitx.dts
> > @@ -83,6 +83,14 @@
> >  			interrupts = <15 0x8>;
> >  			interrupt-parent = <&ipic>;
> >  			dfsrr;
> > +
> > +			rtc@68 {
> > +				device_type = "rtc";
> > +				compatible = "dallas,ds1339";
> > +				reg = <0x68>;
> > +				interrupts = <18 0x8>;
> > +				interrupt-parent = <&ipic>;
> > +			};
> 
> Why are we adding more device_types?

It seems that CHRP is using the device_type for rtc devices, which
means that real OF also provide it. But I guess we don't need it,
right? Then we should cleanup all the boards.