public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Nathan Lynch <ntl@pobox•com>
To: Milton Miller <miltonm@bga•com>
Cc: linuxppc-dev@ozlabs•org, paulus@samba•org
Subject: Re: [PATCH] hide attr_smt_snooze_delay reference with CONFIG_PPC64
Date: Mon, 24 Nov 2008 15:19:54 -0600	[thread overview]
Message-ID: <20081124211954.GE6830@localdomain> (raw)
In-Reply-To: <3122687188274b0dc514.424238335.miltonm@bga.com>

Milton Miller wrote:
> attr_smt_snooze_delay is defined for CONFIG_PPC64, so protect the attribute
> removal with the same condition.
> 
> /data/home/miltonm/next.git/arch/powerpc/kernel/sysfs.c: In function ‘unregister_cpu_online’:
> /data/home/miltonm/next.git/arch/powerpc/kernel/sysfs.c:722: error: ‘attr_smt_snooze_delay’ undeclared (first use in this function)
> /data/home/miltonm/next.git/arch/powerpc/kernel/sysfs.c:722: error: (Each undeclared identifier is reported only once
> /data/home/miltonm/next.git/arch/powerpc/kernel/sysfs.c:722: error: for each function it appears in.)

Is this one going in?  The build is also broken for powermac 32-bit
SMP with HOTPLUG_CPU=y (which I can't figure out how to turn off,
grr).  And this isn't confined to -next; mainline is broken too.

      reply	other threads:[~2008-11-24 21:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-16 21:44 [PATCH] hide attr_smt_snooze_delay reference with CONFIG_PPC64 Milton Miller
2008-11-24 21:19 ` Nathan Lynch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081124211954.GE6830@localdomain \
    --to=ntl@pobox$(echo .)com \
    --cc=linuxppc-dev@ozlabs$(echo .)org \
    --cc=miltonm@bga$(echo .)com \
    --cc=paulus@samba$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox