Subject: Re: adding of_platform_drivers (was: Re: [RESEND][PATCH] uio: Add of_platform_driver to uio_pdrv_genirq)

From: Greg KH <[email-masked]>
Date: Tue, 16 Dec 2008 09:16:46 -0800

On Tue, Dec 16, 2008 at 01:27:32PM +0100, Wolfram Sang wrote:
> > > +/* ---------------------------------------------------------------------
> > > + * OF bus binding
> > > + */
> > > +
> > > +#if defined(CONFIG_OF)
> > 
> > Same goes here, don't put #if in .c files please.
> 
> So, generally speaking, this means that I should not put a
> platform_driver and an of_platform_driver into one source file, but
> rather create an of_$DRIVER.c then?

Yes, this is the preferred way to do it.

thanks,

greg k-h