Subject: Re: [PATCH] powerpc/qe: Select QE_USB with USB_GADGET_FSL_QE

From: Anton Vorontsov <[email-masked]>
Date: Tue, 23 Dec 2008 20:22:58 +0300

On Wed, Dec 03, 2008 at 10:33:27PM +0300, Anton Vorontsov wrote:
> On Sat, Nov 08, 2008 at 08:52:54PM +0300, Anton Vorontsov wrote:
> > Boards should know when QE_USB is used, so that they can configure USB
> > clocks and pins.
> > 
> > Another option would be to add 'select QE_USB' into USB_GADGET_FSL_QE,
> > but selects are evil since they don't support dependencies.
> > 
> > While at it, also remove 'host' from the symbol description, since the
> > QE_USB code is used to support the gadget driver as well.
> > 
> > Signed-off-by: Anton Vorontsov <[email-masked]>
> > ---
> 
> Anything wrong with this one?

Without this patch QE UDC won't work (board file won't configure the
USB clocks and pins).

Thanks,

> >  arch/powerpc/sysdev/qe_lib/Kconfig |    3 ++-
> >  1 files changed, 2 insertions(+), 1 deletions(-)
> > 
> > diff --git a/arch/powerpc/sysdev/qe_lib/Kconfig b/arch/powerpc/sysdev/qe_lib/Kconfig
> > index 76ffbc4..41ac3df 100644
> > --- a/arch/powerpc/sysdev/qe_lib/Kconfig
> > +++ b/arch/powerpc/sysdev/qe_lib/Kconfig
> > @@ -22,5 +22,6 @@ config UCC
> >  
> >  config QE_USB
> >  	bool
> > +	default y if USB_GADGET_FSL_QE
> >  	help
> > -	  QE USB Host Controller support
> > +	  QE USB Controller support
> > -- 
> > 1.5.6.3

-- 
Anton Vorontsov
email: [email-masked]
irc://irc.freenode.net/bd2