public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Anton Vorontsov <avorontsov@ru•mvista.com>
To: Alan Stern <stern@rowland•harvard.edu>
Cc: David Brownell <dbrownell@users•sourceforge.net>,
	Greg Kroah-Hartman <greg@kroah•com>,
	linux-usb@vger•kernel.org, linux-kernel@vger•kernel.org,
	linuxppc-dev@ozlabs•org,
	Andrew Morton <akpm@linux-foundation•org>,
	Li Yang <leoli@freescale•com>, Timur Tabi <timur@freescale•com>
Subject: Re: [PATCH] USB: Driver for Freescale QUICC Engine USB Host Controller
Date: Wed, 24 Dec 2008 22:11:43 +0300	[thread overview]
Message-ID: <20081224191143.GA11060@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0812232140400.8076-100000@netrider.rowland.org>

On Tue, Dec 23, 2008 at 09:45:09PM -0500, Alan Stern wrote:
> On Wed, 24 Dec 2008, Anton Vorontsov wrote:
> 
> > This patch adds support for the FHCI USB controller, as found
> > in the Freescale MPC836x and MPC832x processors. It can support
> > Full or Low speed modes.
> > 
> > Quite a lot the hardware is doing by itself (SOF generation, CRC
> > generation and checking), though scheduling and retransmission is on
> > software's shoulders.
> > 
> > This controller does not integrate the root hub, so this driver also
> > fakes one-port hub. External hub is required to support more than
> > one device.
> 
> It looks like the kernel this was written for is several versions out 
> of date.

Yeah, originally it was written for 2.6.10. Though the driver I
posted is for the linux-next, and it works quite well w/o the
{un,}link_urb calls. ;-)

> The driver is missing some critical calls to functions like 
> usb_hcd_link_urb_to_ep().

Fixed.

Thanks for review!

-- 
Anton Vorontsov
email: cbouatmailru@gmail•com
irc://irc.freenode.net/bd2

  reply	other threads:[~2008-12-24 19:11 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-23 21:03 [PATCH] USB: Driver for Freescale QUICC Engine USB Host Controller Anton Vorontsov
2008-12-23 21:28 ` Andrew Morton
2008-12-24 19:11   ` Anton Vorontsov
2008-12-24  2:45 ` Alan Stern
2008-12-24 19:11   ` Anton Vorontsov [this message]
2008-12-24 19:13 ` [PATCH -mm 1/3] USB: FHCI: Driver should be responsible for managing endpoint queues Anton Vorontsov
2008-12-24 19:59   ` Greg KH
2008-12-24 20:08     ` Anton Vorontsov
2008-12-24 20:18       ` Andrew Morton
2008-12-24 20:53         ` [PATCH v2] USB: Driver for Freescale QUICC Engine USB Host Controller Anton Vorontsov
2008-12-24 20:58         ` [PATCH -mm 1/3] USB: FHCI: Driver should be responsible for managing endpoint queues Greg KH
2008-12-24 21:07           ` Anton Vorontsov
2008-12-24 22:54   ` Alan Stern
2008-12-24 19:13 ` [PATCH -mm 2/3] USB: FHCI: Fix namespace pollution Anton Vorontsov
2008-12-24 19:13 ` [PATCH -mm 3/3] USB: FHCI: Fix memory leaks in fhci_mem_{init,free} Anton Vorontsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081224191143.GA11060@oksana.dev.rtsoft.ru \
    --to=avorontsov@ru$(echo .)mvista.com \
    --cc=akpm@linux-foundation$(echo .)org \
    --cc=dbrownell@users$(echo .)sourceforge.net \
    --cc=greg@kroah$(echo .)com \
    --cc=leoli@freescale$(echo .)com \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-usb@vger$(echo .)kernel.org \
    --cc=linuxppc-dev@ozlabs$(echo .)org \
    --cc=stern@rowland$(echo .)harvard.edu \
    --cc=timur@freescale$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox