Subject: Re: [PATCH 3/5] powerpc: Bootwrapper and serial console support for AmigaOne

From: "Gerhard Pircher" <[email-masked]>
Date: Wed, 07 Jan 2009 16:20:35 +0100

-------- Original-Nachricht --------
> Datum: Wed, 7 Jan 2009 08:07:14 -0700
> Von: "Grant Likely" <[email-masked]>
> An: "Gerhard Pircher" <[email-masked]>
> CC: [email-masked]
> Betreff: Re: [PATCH 3/5] powerpc: Bootwrapper and serial console support for AmigaOne

> On Wed, Jan 7, 2009 at 7:03 AM, Gerhard Pircher <[email-masked]>
> wrote:
> > diff --git a/arch/powerpc/boot/serial.c b/arch/powerpc/boot/serial.c
> > index 8b3607c..f2156f0 100644
> > --- a/arch/powerpc/boot/serial.c
> > +++ b/arch/powerpc/boot/serial.c
> > @@ -117,7 +117,8 @@ int serial_console_init(void)
> >        if (devp == NULL)
> >                goto err_out;
> >
> > -       if (dt_is_compatible(devp, "ns16550"))
> > +       if (dt_is_compatible(devp, "ns16550") ||
> > +           dt_is_compatible(devp, "pnpPNP,501"))
> >                rc = ns16550_console_init(devp, &serial_cd);
> 
> Why not just claim "ns16550" compatibility in the device tree node?
It was suggested that I should use PNP identifiers for all ISA devices, as
these are part of a real PCI2ISA bridge (when I sent the previous version
or these patches).

Gerhard

-- 
Sensationsangebot verlängert: GMX FreeDSL - Telefonanschluss + DSL 
für nur 16,37 Euro/mtl.!* http://dsl.gmx.de/?ac=OM.AD.PD003K1308T4569a