From: "John W. Linville" <linville@tuxdriver•com>
To: Gerhard Pircher <gerhard_pircher@gmx•net>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH v2 1/4] Add platform support for AmigaOne
Date: Wed, 4 Feb 2009 16:39:14 -0500 [thread overview]
Message-ID: <20090204213914.GB15411@tuxdriver.com> (raw)
In-Reply-To: <20090204213531.164090@gmx.net>
On Wed, Feb 04, 2009 at 10:35:31PM +0100, Gerhard Pircher wrote:
>
> -------- Original-Nachricht --------
> > Datum: Wed, 4 Feb 2009 21:59:41 +0100
> > Von: Gabriel Paubert <paubert@iram•es>
> > An: Benjamin Herrenschmidt <benh@kernel•crashing.org>
> > CC: Gerhard Pircher <gerhard_pircher@gmx•net>, linuxppc-dev list <linuxppc-dev@ozlabs•org>
> > Betreff: Re: [PATCH v2 1/4] Add platform support for AmigaOne
>
> > On Wed, Feb 04, 2009 at 02:50:07PM +1100, Benjamin Herrenschmidt wrote:
> > >
> > > > + hose->first_busno = bus_range ? bus_range[0] : 0;
> > > > + hose->last_busno = bus_range ? bus_range[1] : 0xff;
> > > > +
> > > > + setup_indirect_pci(hose, 0xfec00cf8, 0xfee00cfc, 0);
> > >
> > > Minor in the context of amigaone but still... the above should come
> > > from the device-tree... I suppose those are really just IO space
> > > addresses cf8 and cfc, in which case, an option is to call that first:
> >
> > Hmm, the first is feC...,the other one feE..., 2Mbytes apart.
> >
> > I don't know the hardware but I've never seen something like that.
> > Of course a typo is always a possibility...
> The Pegasos 1 uses the same northbridge and chrp_find_bridges() calls
> setup_indirect_pci() with the same addresses.
As a proud owner, I concur that those numbers are correct...
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver•com might be all we have. Be ready.
prev parent reply other threads:[~2009-02-04 21:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-02 21:21 AmigaOne platform patches v2 Gerhard Pircher
2009-02-02 21:39 ` [PATCH v2 1/4] Add platform support for AmigaOne Gerhard Pircher
2009-02-04 3:50 ` Benjamin Herrenschmidt
2009-02-04 12:09 ` Gerhard Pircher
2009-02-04 20:47 ` Benjamin Herrenschmidt
2009-02-05 13:36 ` [RFC] Error handling in *_add/find_bridges() Gerhard Pircher
2009-02-04 20:59 ` [PATCH v2 1/4] Add platform support for AmigaOne Gabriel Paubert
2009-02-04 21:35 ` Gerhard Pircher
2009-02-04 21:39 ` John W. Linville [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090204213914.GB15411@tuxdriver.com \
--to=linville@tuxdriver$(echo .)com \
--cc=gerhard_pircher@gmx$(echo .)net \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox