Subject: Re: [PATCH] powerpc/83xx: Add power management support for MPC837x boards

From: Anton Vorontsov <[email-masked]>
Date: Fri, 20 Feb 2009 20:37:17 +0300

On Fri, Feb 20, 2009 at 11:31:09AM -0600, Scott Wood wrote:
> Anton Vorontsov wrote:
>> diff --git a/arch/powerpc/boot/dts/mpc8377_mds.dts b/arch/powerpc/boot/dts/mpc8377_mds.dts
>> index 3e3ec8f..c54b90d 100644
>> --- a/arch/powerpc/boot/dts/mpc8377_mds.dts
>> +++ b/arch/powerpc/boot/dts/mpc8377_mds.dts
>> @@ -137,6 +137,7 @@
>>  			reg = <0x3000 0x100>;
>>  			interrupts = <14 0x8>;
>>  			interrupt-parent = <&ipic>;
>> +			sleep = <&pmc 0x0c000000>;
>>  			dfsrr;
>
> [snip]
>
>> @@ -318,6 +325,7 @@
>>  			reg = <0x2e000 0x1000>;
>>  			interrupts = <42 0x8>;
>>  			interrupt-parent = <&ipic>;
>> +			sleep = <&pmc 0x0c000000>;
>
> You have two different nodes with the same bits referenced.

Yes, I2C1 and eSDHC are using the same clock source.

> These nodes
> cannot be put to sleep independently, and as such need to be under a
> common sleep-nexus node.

Ah, that's what the sleep-nexus nodes are for... ;-)

Thank you Scott, I'll add the sleep-nexus nodes.

-- 
Anton Vorontsov
email: [email-masked]
irc://irc.freenode.net/bd2