Subject: Re: [PATCH] powerpc/cell: Only build Axon MSI driver for IBM Cell Blades

From: Olof Johansson <[email-masked]>
Date: Thu, 5 Mar 2009 01:13:56 -0600

On Thu, Mar 05, 2009 at 03:41:41PM +1100, Michael Ellerman wrote:
> The hardware is only present on those machines, and the driver
> depends on infrastructure which is selected by the Kconfig for
> cell blades.

Wouldn't it make more sense to make a separate (AXON_MSI) config option
depend on PPC_IBM_CELL_BLADE?

-Olof

> --- a/arch/powerpc/platforms/cell/Makefile
> +++ b/arch/powerpc/platforms/cell/Makefile
> @@ -28,7 +28,9 @@ obj-$(CONFIG_SPU_BASE)			+= spu_callbacks.o spu_base.o \
>  					   $(spu-manage-y) \
>  					   spufs/
>  
> +ifeq ($(CONFIG_PPC_IBM_CELL_BLADE),y)
>  obj-$(CONFIG_PCI_MSI)			+= axon_msi.o
> +endif
>  
>  # qpace setup
>  obj-$(CONFIG_PPC_CELL_QPACE)		+= qpace_setup.o