From: Benjamin Herrenschmidt <benh@kernel•crashing.org>
To: <linuxppc-dev@ozlabs•org>
Subject: [PATCH] powerpc: Fix warnings introduced by sysfs changes
Date: Wed, 25 Mar 2009 12:51:02 +1100 [thread overview]
Message-ID: <20090325015128.C109DDDEFE@ozlabs.org> (raw)
Rusty's patch to change our sysfs access to various registers
to use smp_call_function_single() introduced a whole bunch of
warnings. This fixes them
Signed-off-by: Benjamin Herrenschmidt <benh@kernel•crashing.org>
---
I've also now fixed my build test tool to report warnings properly
so hopefully I won't miss that next time around :-)
arch/powerpc/kernel/sysfs.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
--- linux-work.orig/arch/powerpc/kernel/sysfs.c 2009-03-25 11:17:28.000000000 +1100
+++ linux-work/arch/powerpc/kernel/sysfs.c 2009-03-25 11:18:15.000000000 +1100
@@ -140,11 +140,10 @@ static void read_##NAME(void *val) \
{ \
mtspr(ADDRESS, *(unsigned long *)val); \
} \
-static unsigned long write_##NAME(unsigned long val) \
+static void write_##NAME(void *val) \
{ \
ppc_enable_pmcs(); \
- mtspr(ADDRESS, *(unsigned long *)val); \
- return 0; \
+ mtspr(ADDRESS, *(unsigned long *)val); \
} \
static ssize_t show_##NAME(struct sys_device *dev, \
struct sysdev_attribute *attr, \
reply other threads:[~2009-03-25 1:51 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090325015128.C109DDDEFE@ozlabs.org \
--to=benh@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox