From: Mark Nelson <markn@au1•ibm.com>
To: Utz Bacher <utz.bacher@de•ibm.com>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH] powerpc/wdrtas: Update wdrtas_get_interval to use rtas_data_buf
Date: Wed, 25 Mar 2009 09:53:02 +1100 [thread overview]
Message-ID: <200903250953.02677.markn@au1.ibm.com> (raw)
In-Reply-To: <OF2EBA91DF.87037392-ONC1257583.004A2432-C1257583.004FC7A9@de.ibm.com>
On Wed, 25 Mar 2009 01:31:32 am Utz Bacher wrote:
> Adrian Reber <adrian@lisas•de> wrote on 24.03.2009 13:31:31:
> > On Tue, Mar 24, 2009 at 05:30:41PM +1100, Mark Nelson wrote:
> > > The buffer passed to the ibm,get-system-parameter RTAS call must be
> > > in the RMA. To ensure we pass an address in the RMA use rtas_data_buf
> > > for the actual RTAS call and then copy the result to value. We can't
> > > just make it static because this can be compiled in as a module.
> > >
> > > Also add the WDRTAS_SP_SPI_LEN so we don't litter '4' throughout the
> > > function.
> > >
> > > Signed-off-by: Mark Nelson <markn@au1•ibm.com>
> > > ---
> > >
> > > Adrian, does this patch cause any problems for your pxcabs?
> >
> > No, it even helps. I have no tried the watchdog until now, but without
> the
> > patch I get:
> >
> > wdrtas: could not get sp_spi watchdog timeout (0). Continuing
> >
> > and with the patch it reads the correct value. So only with your patch
> > it works like it is supposed to. Thanks!
> >
> > Tested-by: Adrian Reber <adrian@lisas•de>
>
> looks good to me.
>
> Acked-by: Utz Bacher <utz.bacher@de•ibm.com>
Thanks for looking over it!
Mark
next prev parent reply other threads:[~2009-03-24 22:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-24 6:30 [PATCH] powerpc/wdrtas: Update wdrtas_get_interval to use rtas_data_buf Mark Nelson
2009-03-24 12:31 ` Adrian Reber
2009-03-24 14:31 ` Utz Bacher
2009-03-24 22:53 ` Mark Nelson [this message]
2009-03-24 22:51 ` Mark Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903250953.02677.markn@au1.ibm.com \
--to=markn@au1$(echo .)ibm.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=utz.bacher@de$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox