Subject: Re: [PATCH] ucc_geth: Fix three oopses in PHY {de,}initialization code

From: David Miller <[email-masked]>
Date: Fri, 27 Mar 2009 16:00:29 -0700 (PDT)

From: Anton Vorontsov <[email-masked]>
Date: Fri, 27 Mar 2009 20:40:47 +0300

> When there are no free snums, UCC ethernet should gracefully fail, but
> currently it oopses this way:
 ...
> Also, when device tree specifies fixed-link, and CONFIG_FIXED_PHY
> is disabled, we'll get this oops:
 ...
> This patch fixes all three oopses simply by rearranging some code:
> 
> - In ucc_geth_open(): move init_phy() call to the beginning, so
>   that we only call ucc_geth_stop() with a PHY attached;
> - Move phy_disconnect() call from ucc_geth_close() to
>   ucc_geth_stop(), so that we'll always disconnect the PHY.
> 
> Signed-off-by: Anton Vorontsov <[email-masked]>

Applied, thanks Anton.