From: Anton Vorontsov <avorontsov@ru•mvista.com>
To: Segher Boessenkool <segher@kernel•crashing.org>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs•org>
Subject: Re: Build error
Date: Wed, 1 Apr 2009 00:57:44 +0400 [thread overview]
Message-ID: <20090331205744.GA1156@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <38D8651E-1AB6-4358-AD1F-408E3DB8F4E9@kernel.crashing.org>
On Tue, Mar 31, 2009 at 10:41:38PM +0200, Segher Boessenkool wrote:
>>>>> ERROR: "fsl_pq_mdio_bus_name" [drivers/net/gianfar_driver.ko]
>>>>> undefined!
>>>>>
>>>>> I'll ask Linus to pull anyway though.
>>>>>
>>>>> Cheers,
>>>>> Ben.
>>>>
>>>> I believe this is fixed in net-next (and possible linus has already
>>>> pulled that in.)
>>>
>>> FWIW, I can't reproduce the issue neither in benh/powerpc.git `next'
>>> branch nor in `merge' branch...
>>
>> Ah .. .weird :-)
>
> I had this happen a few days ago already, on Linus' tree. I also told
> you about it (on IRC), but you were too busy or something :-)
>
> A simple ppc6xx_defconfig is enough to reproduce, fwiw.
>
> Here's the patch I used, sorry if my mailer wraps it, it's a one-liner,
> you can handle it I'm sure :-)
Ah, the modular build. Yeah, I didn't try it, but should have... :-(
Thanks!
> Segher
>
>
> Signed-off-by: Segher Boessenkool <segher@kernel•crashing.org>
>
>
> Author: Segher Boessenkool <segher@kernel•crashing.org>
> Date: Fri Mar 27 21:10:59 2009 +0100
>
> powerpc: EXPORT_SYMBOL_GPL(fsl_pq_mdio_bus_name)
>
> diff --git a/drivers/net/fsl_pq_mdio.c b/drivers/net/fsl_pq_mdio.c
> index b3079a5..a108332 100644
> --- a/drivers/net/fsl_pq_mdio.c
> +++ b/drivers/net/fsl_pq_mdio.c
> @@ -204,6 +204,7 @@ void fsl_pq_mdio_bus_name(char *name, struct
> device_node *np
> snprintf(name, MII_BUS_ID_SIZE, "%s@%llx", np->name,
> (unsigned long long)taddr);
> }
> +EXPORT_SYMBOL_GPL(fsl_pq_mdio_bus_name);
>
> /* Scan the bus in reverse, looking for an empty spot */
> static int fsl_pq_mdio_find_free(struct mii_bus *new_bus)
>
--
Anton Vorontsov
email: cbouatmailru@gmail•com
irc://irc.freenode.net/bd2
next prev parent reply other threads:[~2009-03-31 20:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-30 3:25 Build error Benjamin Herrenschmidt
2009-03-30 13:51 ` Kumar Gala
2009-03-30 13:59 ` Anton Vorontsov
2009-03-30 23:18 ` Benjamin Herrenschmidt
2009-03-31 20:41 ` Segher Boessenkool
2009-03-31 20:54 ` Grant Likely
2009-03-31 20:57 ` Anton Vorontsov [this message]
2009-03-31 20:52 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090331205744.GA1156@oksana.dev.rtsoft.ru \
--to=avorontsov@ru$(echo .)mvista.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=segher@kernel$(echo .)crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox