From: Olof Johansson <olof@lixom•net>
To: Michael Ellerman <michael@ellerman•id.au>
Cc: linuxppc-dev@ozlabs•org, Kumar Gala <kumar.gala@freescale•com>
Subject: Re: [PATCH] powerpc: Add configurable -Werror for arch/powerpc
Date: Tue, 7 Apr 2009 09:11:54 -0500 [thread overview]
Message-ID: <20090407141154.GA30654@lixom.net> (raw)
In-Reply-To: <1239073293.6565.18.camel@localhost>
On Tue, Apr 07, 2009 at 03:01:33AM +0000, Michael Ellerman wrote:
> On Mon, 2009-04-06 at 21:27 -0500, Olof Johansson wrote:
> > On Tue, Apr 07, 2009 at 12:00:41PM +1000, Michael Ellerman wrote:
> > > Add an option, on by default, to build all code under arch/powerpc with
> > > -Werror, which causes gcc to treat warnings as errors.
> > >
> > > The intention is to make it harder for people to inadvertantly introduce
> > > errors in the arch/powerpc code. It needs to be configurable so that
> > > if a warning is introduced, people can easily work around it while it's
> > > being fixed.
> >
> > This looks useful at least for the automated builds to catch new warnings,
> > but do similar options exist on other architectures, x86 in particular? I
> > think a Cc to LKML of this could be useful.
> >
> > This is really only beneficial if various people build for powerpc often
> > enough. If major subsystem maintainers aren't going to hit the errors
> > it's more of a hinderance for PPC than a global benefit, right?
>
> I don't think so. We're only enabling it for code under arch/powerpc -
> and most modifications to that code should come through linuxppc.
Good point.
> It's still possible that random stuff will get merged, or that someone
> will change code in a header that only causes warnings on powerpc, but
> it's less likely.
>
> And that's why it's an option, if someone breaks the build we can work
> around it until they're appropriately LARTed.
Yeah, sounds good to me.
-Olof
next prev parent reply other threads:[~2009-04-07 14:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-07 2:00 [PATCH] powerpc: Add configurable -Werror for arch/powerpc Michael Ellerman
2009-04-07 2:27 ` Olof Johansson
2009-04-07 2:28 ` David Miller
2009-04-07 2:37 ` Olof Johansson
2009-04-07 3:01 ` Michael Ellerman
2009-04-07 14:11 ` Olof Johansson [this message]
2009-04-07 7:41 ` Geert Uytterhoeven
2009-04-07 7:50 ` Stephen Rothwell
2009-04-07 15:05 ` Kumar Gala
-- strict thread matches above, loose matches on Subject: below --
2009-06-10 6:48 Michael Ellerman
2009-06-15 7:50 ` Michael Ellerman
2009-06-15 9:40 ` Benjamin Herrenschmidt
2009-06-15 12:36 ` Michael Ellerman
2009-06-15 21:23 ` Benjamin Herrenschmidt
2009-06-15 14:54 ` Timur Tabi
2009-06-18 14:22 ` Arnd Bergmann
2009-04-06 4:18 Michael Ellerman
2009-04-06 12:55 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090407141154.GA30654@lixom.net \
--to=olof@lixom$(echo .)net \
--cc=kumar.gala@freescale$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=michael@ellerman$(echo .)id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox