From: Anton Vorontsov <avorontsov@ru•mvista.com>
To: Anatolij Gustschin <agust@denx•de>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH] powerpc: 85xx: Add PHY fixup to socrates board code
Date: Tue, 7 Apr 2009 22:40:34 +0400 [thread overview]
Message-ID: <20090407184034.GA25760@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <20090407180957.GA2831@oksana.dev.rtsoft.ru>
On Tue, Apr 07, 2009 at 10:09:57PM +0400, Anton Vorontsov wrote:
[...]
> Still, I think you shouldn't do this in a board-specific fixup.
> Maybe I'm a bit naive, but shouldn't this work too?
Yes, I'm naive. The phydev isn't yet bound to any driver, so we
can't call phy_disable_interrupts().
And I don't see any proper solution. :-( After all, it appears
we'll have to live with the board fixup.
> diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c
> index b754020..9052937 100644
> --- a/drivers/net/phy/mdio_bus.c
> +++ b/drivers/net/phy/mdio_bus.c
> @@ -205,6 +205,16 @@ struct phy_device *mdiobus_scan(struct mii_bus *bus, int addr)
>
> phydev->bus = bus;
>
> + /*
> + * Some PHYs may have unmasked/pending interrupts, this might
> + * cause troubles w/ shared IRQs. So try to put the PHYs into
> + * some sane state.
> + *
> + * NOTE: This won't work if you have two PHYs w/ shared IRQs
> + * on different MDIO buses.
> + */
> + phy_disable_interrupts(phydev);
> +
> /* Run all of the fixups for this PHY */
> phy_scan_fixups(phydev);
>
--
Anton Vorontsov
email: cbouatmailru@gmail•com
irc://irc.freenode.net/bd2
next prev parent reply other threads:[~2009-04-07 18:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-07 14:19 [PATCH] powerpc: 85xx: Add PHY fixup to socrates board code Anatolij Gustschin
2009-04-07 14:30 ` Anton Vorontsov
2009-04-07 17:24 ` Anatolij Gustschin
2009-04-07 18:09 ` Anton Vorontsov
2009-04-07 18:40 ` Anton Vorontsov [this message]
2009-04-21 17:19 ` [PATCH v2] " Anatolij Gustschin
2009-04-21 21:54 ` Kumar Gala
2009-04-21 22:04 ` Kumar Gala
2009-04-21 23:24 ` Anatolij Gustschin
2009-06-16 13:46 ` Kumar Gala
2009-06-23 10:15 ` Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090407184034.GA25760@oksana.dev.rtsoft.ru \
--to=avorontsov@ru$(echo .)mvista.com \
--cc=agust@denx$(echo .)de \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox