From: Jean Delvare <khali@linux-fr•org>
To: Takashi Iwai <tiwai@suse•de>
Cc: alsa-devel@alsa-project•org, linuxppc-dev@ozlabs•org
Subject: Re: [PATCH] keywest: Convert to new-style i2c driver
Date: Tue, 21 Apr 2009 11:44:13 +0200 [thread overview]
Message-ID: <20090421114413.61e52817@hyperion.delvare> (raw)
In-Reply-To: <20090421112300.467e9f9b@hyperion.delvare>
On Tue, 21 Apr 2009 11:23:00 +0200, Jean Delvare wrote:
> On Tue, 21 Apr 2009 08:31:00 +0200, Takashi Iwai wrote:
> > At Mon, 20 Apr 2009 22:56:59 +0200,
> > Jean Delvare wrote:
> > >
> > > The legacy i2c binding model is going away soon, so convert the ppc
> > > keywest sound driver to the new model or it will break.
> > >
> > > Signed-off-by: Jean Delvare <khali@linux-fr•org>
> > > Cc: Benjamin Herrenschmidt <benh@kernel•crashing.org>
> > > Cc: Takashi Iwai <tiwai@suse•de>
> > > ---
> > > Takashi, please push this patch to Linus quickly, as this is blocking
> > > the removal of the legacy i2c binding model, which is scheduled for
> > > 2.6.30.
> > >
> > > I did not get any test report for this one, but it's relatively simple
> > > so I am confident I got it right.
> >
> > Applied this one, too. Thanks.
>
> Thanks Takashi.
>
> BTW, I forgot to mention again that the new i2c binding model is
> functional since kernel 2.6.25, so for the external alsa driver tree
> you will want to guard these changes with appropriate ifdef magic.
Err, make that 2.6.30, sorry. While the infrastructure was there since
2.6.25, the way I converted the sound drivers doesn't fit in what
earlier kernels considered acceptable (the checks on which driver
methods were implemented was a little too strict IMHO). So the
converted drivers can only be used with kernels >= 2.6.30.
--
Jean Delvare
prev parent reply other threads:[~2009-04-21 9:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-20 20:56 [PATCH] keywest: Convert to new-style i2c driver Jean Delvare
2009-04-20 22:34 ` Paul Mackerras
2009-04-21 6:33 ` Takashi Iwai
2009-04-21 9:33 ` Paul Mackerras
2009-04-21 9:36 ` Takashi Iwai
2009-04-21 9:48 ` Jean Delvare
2009-04-21 9:56 ` Wolfram Sang
2009-04-22 9:34 ` Paul Mackerras
2009-04-22 12:04 ` Jean Delvare
2009-04-22 12:56 ` Paul Mackerras
2009-04-22 14:24 ` Takashi Iwai
2009-04-23 9:54 ` Jean Delvare
2009-04-21 6:31 ` Takashi Iwai
2009-04-21 9:23 ` Jean Delvare
2009-04-21 9:30 ` Takashi Iwai
2009-04-21 9:44 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090421114413.61e52817@hyperion.delvare \
--to=khali@linux-fr$(echo .)org \
--cc=alsa-devel@alsa-project$(echo .)org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=tiwai@suse$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox