From: Arnd Bergmann <arnd@arndb•de>
To: Randy Dunlap <randy.dunlap@oracle•com>
Cc: sachinp <sachinp@linux•vnet.ibm.com>,
Stephen Rothwell <sfr@canb•auug.org.au>, samr <sam@ravnborg•org>,
linux-usb@vger•kernel.org,
linux-kernel <linux-kernel@vger•kernel.org>,
David Brownell <david-b@pacbell•net>,
Linuxppc-dev <Linuxppc-dev@ozlabs•org>,
linux-next <linux-next@vger•kernel.org>,
subrata@linux•vnet.ibm.com,
Alexander Beregalov <a.beregalov@gmail•com>
Subject: Re: [BUILD FAILURE 11/12] Next April 21 : PPC64 randconfig [drivers/usb/host/ohci-hcd.o]
Date: Wed, 22 Apr 2009 09:30:00 +0200 [thread overview]
Message-ID: <200904220930.01735.arnd@arndb.de> (raw)
In-Reply-To: <49EE8855.1080306@oracle.com>
On Wednesday 22 April 2009, Randy Dunlap wrote:
> > Is there maybe a way to force Kconfig to just reject
> > such illegal configs -- neither option set -- rather
> > than trying some how to fix it?
>=20
> Not that I know of. =A0cc-ing Sam.
We could just make the USB_OHCI_HCD_PPC_OF option implicit
and selected only if at least one of USB_OHCI_HCD_PPC_OF_BE
and USB_OHCI_HCD_PPC_OF_LE are set.
Signed-off-by: Arnd Bergmann <arnd@arndb•de>
diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
index 845479f..07e3e25 100644
=2D-- a/drivers/usb/host/Kconfig
+++ b/drivers/usb/host/Kconfig
@@ -161,26 +161,26 @@ config USB_OHCI_HCD_PPC_SOC
Enables support for the USB controller on the MPC52xx or
STB03xxx processor chip. If unsure, say Y.
=20
=2Dconfig USB_OHCI_HCD_PPC_OF
=2D bool "OHCI support for PPC USB controller on OF platform bus"
=2D depends on USB_OHCI_HCD && PPC_OF
=2D default y
=2D ---help---
=2D Enables support for the USB controller PowerPC present on the
=2D OpenFirmware platform bus.
=2D
config USB_OHCI_HCD_PPC_OF_BE
=2D bool "Support big endian HC"
=2D depends on USB_OHCI_HCD_PPC_OF
=2D default y
+ bool "OHCI support for OF platform bus (big endian)"
+ depends on USB_OHCI_HCD && PPC_OF
select USB_OHCI_BIG_ENDIAN_DESC
select USB_OHCI_BIG_ENDIAN_MMIO
+ ---help---
+ Enables support for big-endian USB controllers present on the
+ OpenFirmware platform bus.
=20
config USB_OHCI_HCD_PPC_OF_LE
=2D bool "Support little endian HC"
=2D depends on USB_OHCI_HCD_PPC_OF
=2D default n
+ bool "OHCI support for OF platform bus (little endian)"
+ depends on USB_OHCI_HCD && PPC_OF
select USB_OHCI_LITTLE_ENDIAN
+ ---help---
+ Enables support for little-endian USB controllers present on the
+ OpenFirmware platform bus.
+
+config USB_OHCI_HCD_PPC_OF
+ bool
+ default USB_OHCI_HCD_PPC_OF_BE || USB_OHCI_HCD_PPC_OF_LE
=20
config USB_OHCI_HCD_PCI
bool "OHCI support for PCI-bus USB controllers"
prev parent reply other threads:[~2009-04-22 7:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-21 18:54 [BUILD FAILURE 11/12] Next April 21 : PPC64 randconfig [drivers/usb/host/ohci-hcd.o] Subrata Modak
2009-04-21 19:03 ` David Brownell
2009-04-21 21:37 ` Kumar Gala
2009-04-21 22:05 ` Randy Dunlap
2009-04-22 2:19 ` David Brownell
2009-04-22 3:00 ` Randy Dunlap
2009-04-22 7:30 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904220930.01735.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=Linuxppc-dev@ozlabs$(echo .)org \
--cc=a.beregalov@gmail$(echo .)com \
--cc=david-b@pacbell$(echo .)net \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=randy.dunlap@oracle$(echo .)com \
--cc=sachinp@linux$(echo .)vnet.ibm.com \
--cc=sam@ravnborg$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=subrata@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox