From: Arnd Bergmann <arnd@arndb•de>
To: linuxppc-dev@ozlabs•org
Cc: Stephen Neuendorffer <stephenn@xilinx•com>,
linux-kernel@vger•kernel.org, microblaze-uclinux@itee•uq.edu.au,
John Linn <John.Linn@xilinx•com>,
John Williams <john.williams@petalogix•com>
Subject: Re: [microblaze-uclinux] [PATCH 11/11] microblaze: Kconfig: Enable drivers for Microblaze
Date: Fri, 24 Apr 2009 12:49:48 +0200 [thread overview]
Message-ID: <200904241249.49870.arnd@arndb.de> (raw)
In-Reply-To: <1d3f23370904201924n4ab592cdq49a4a4c8ec78d1df@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 814 bytes --]
On Tuesday 21 April 2009, John Williams wrote:
> Some (most?) of the Xilinx drivers currently have this construct:
>
> #ifdef CONFIG_OF
>
> // probe using OF
>
> #else
If there are multiple ways of detecting the device, then
the driver should be compilable on any system that allows
either one.
At the very least, it should be restricted to CONFIG_HAS_IOMEM,
which is probably required for any of these, but not provided
on stuff like UML or s390.
Drivers that use of_* functions unconditionally need to
depend on CONFIG_OF.
Also, some of the xilinx drivers apparantly use DCR, which in turn is
only defined when you have CONFIG_PPC_DCR, and these
have so far only been used on powerpc. If other architectures
start using DCR (I hope that never happens), we will need a
global CONFIG_DCR option.
Arnd <><
[-- Attachment #2: Type: text/html, Size: 5105 bytes --]
next prev parent reply other threads:[~2009-04-24 10:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <764365e7af2e476e43cd674738e51f13b306979b.1239874968.git.monstr@monstr.eu>
[not found] ` <74c0088dfda1816c21914c0a8da0c42908526c5e.1239874968.git.monstr@monstr.eu>
[not found] ` <20090417170707.B6C95C4004F@mail150-wa4.bigfish.com>
2009-04-18 5:49 ` [microblaze-uclinux] [PATCH 11/11] microblaze: Kconfig: Enable drivers for Microblaze Grant Likely
2009-04-19 2:41 ` Stephen Neuendorffer
2009-04-19 23:03 ` John Williams
2009-04-20 5:51 ` Stephen Neuendorffer
[not found] ` <977C41F842E66D4CB2E41332313B6150069D3D27@XSJ-EXCHVS1.xlnx.xilinx.com>
2009-04-20 14:36 ` John Linn
2009-04-20 14:48 ` Grant Likely
2009-04-21 2:24 ` John Williams
2009-04-24 10:49 ` Arnd Bergmann [this message]
2009-04-19 9:25 ` who know's what is "TestFloat cases" and how to test this feature on the Freescale MPC8536DS board derekzheng
2009-04-19 16:40 ` Kumar Gala
2009-04-20 5:29 ` zhengxiang9
2009-04-20 7:41 ` who know's what is "TestFloat cases" and how to test this feature onthe " Liu Yu-B13201
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904241249.49870.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=John.Linn@xilinx$(echo .)com \
--cc=john.williams@petalogix$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=microblaze-uclinux@itee$(echo .)uq.edu.au \
--cc=stephenn@xilinx$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox