From: David Miller <davem@davemloft•net>
To: rbrito@ime•usp.br
Cc: linuxppc-dev@ozlabs•org, paulus@samba•org,
linux-kernel@vger•kernel.org, netdev@vger•kernel.org
Subject: Re: [PATCH] powerpc: convert mace to netdev_ops
Date: Mon, 27 Apr 2009 05:42:58 -0700 (PDT) [thread overview]
Message-ID: <20090427.054258.16622932.davem@davemloft.net> (raw)
In-Reply-To: <20090427121633.GA29608@ime.usp.br>
From: Rog=E9rio Brito <rbrito@ime•usp.br>
Date: Mon, 27 Apr 2009 09:16:33 -0300
> Is this anything close to what needs to be done? It's not without
> failures, because the function mace_set_timeout receives a pointer to=
a
> struct net_device, but is marked inline and is used by mace_tx_timeou=
t,
> which receives an unsigned long (which calls mace_set_timeout).
> =
> Perhaps it would be a case of removing the inline hint to the compile=
r?
> I guess that BenH or Paul could comment here better...
> =
> Signed-off-by: Rog=E9rio Brito <rbrito@ime•usp.br>
You can fix the mace_set_timeout() function arguments by having
a helper function that simply wraps around it and provides the
second expection of argument types.
Your patch is also wrong, it's missing a lot of netdev_ops
entries that are implicitly obtained via alloc_etherdev(),
namely:
.ndo_change_mtu =3D eth_change_mtu,
.ndo_set_mac_address =3D eth_mac_addr,
.ndo_validate_addr =3D eth_validate_addr,
next prev parent reply other threads:[~2009-04-27 12:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-26 15:57 [2.6.30-rc3] powerpc: compilation error of mace module Rogério Brito
2009-04-27 6:06 ` David Miller
2009-04-27 12:16 ` [PATCH] powerpc: convert mace to netdev_ops (was: Re: [2.6.30-rc3] powerpc: compilation error of mace module) Rogério Brito
2009-04-27 12:42 ` David Miller [this message]
2009-04-27 14:20 ` [PATCH] powerpc: convert mace to netdev_ops Rogério Brito
2009-05-03 11:48 ` Rogério Brito
2009-05-03 21:15 ` David Miller
2009-05-03 21:20 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090427.054258.16622932.davem@davemloft.net \
--to=davem@davemloft$(echo .)net \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=paulus@samba$(echo .)org \
--cc=rbrito@ime$(echo .)usp.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox