From: David Miller <davem@davemloft•net>
To: galak@kernel•crashing.org
Cc: linuxppc-dev@ozlabs•org, netdev@vger•kernel.org
Subject: Re: [PATCH] gianfar: Use memset instead of cacheable_memzero
Date: Tue, 28 Apr 2009 08:04:20 -0700 (PDT) [thread overview]
Message-ID: <20090428.080420.86723596.davem@davemloft.net> (raw)
In-Reply-To: <1240928041-10905-1-git-send-email-galak@kernel.crashing.org>
From: Kumar Gala <galak@kernel•crashing.org>
Date: Tue, 28 Apr 2009 09:14:01 -0500
> cacheable_memzero() is completely overkill for the clearing out the FCB
> block which is only 8-bytes. The compiler should easily optimize this
> with memset. Additionally, cacheable_memzero() only exists on ppc32 and
> thus breaks builds of gianfar on ppc64.
>
> Signed-off-by: Kumar Gala <galak@kernel•crashing.org>
Applied to net-next-2.6, thanks!
prev parent reply other threads:[~2009-04-28 15:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-28 14:14 [PATCH] gianfar: Use memset instead of cacheable_memzero Kumar Gala
2009-04-28 15:04 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090428.080420.86723596.davem@davemloft.net \
--to=davem@davemloft$(echo .)net \
--cc=galak@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox