* [PATCH] net/fs_enet/mii-fec: Use PHY_POLL instead of hard coded '-1'
@ 2009-05-08 14:00 Wolfram Sang
2009-05-08 15:55 ` Grant Likely
0 siblings, 1 reply; 3+ messages in thread
From: Wolfram Sang @ 2009-05-08 14:00 UTC (permalink / raw)
To: w.sang; +Cc: netdev, linuxppc-dev, Vitaly Bordug
Initialize the irq-table with PHY_POLL. '-1' means the same now, but is
hardly maintainable.
Signed-off-by: Wolfram Sang <w.sang@pengutronix•de>
Cc: Vitaly Bordug <vbordug@ru•mvista.com>
Cc: Pantelis Antoniou <pantelis.antoniou@gmail•com>
Cc: Grant Likely <grant.likely@secretlab•ca>
Cc: netdev@vger•kernel.org
Cc: linuxppc-dev@ozlabs•org
---
drivers/net/fs_enet/mii-fec.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/fs_enet/mii-fec.c b/drivers/net/fs_enet/mii-fec.c
index 28077cc..9eb5480 100644
--- a/drivers/net/fs_enet/mii-fec.c
+++ b/drivers/net/fs_enet/mii-fec.c
@@ -166,7 +166,7 @@ static int __devinit fs_enet_mdio_probe(struct of_device *ofdev,
goto out_unmap_regs;
for (i = 0; i < PHY_MAX_ADDR; i++)
- new_bus->irq[i] = -1;
+ new_bus->irq[i] = PHY_POLL;
while ((np = of_get_next_child(ofdev->node, np)))
if (!strcmp(np->type, "ethernet-phy"))
--
1.6.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net/fs_enet/mii-fec: Use PHY_POLL instead of hard coded '-1'
2009-05-08 14:00 [PATCH] net/fs_enet/mii-fec: Use PHY_POLL instead of hard coded '-1' Wolfram Sang
@ 2009-05-08 15:55 ` Grant Likely
2009-05-08 16:06 ` Wolfram Sang
0 siblings, 1 reply; 3+ messages in thread
From: Grant Likely @ 2009-05-08 15:55 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linuxppc-dev, netdev, Vitaly Bordug
On Fri, May 8, 2009 at 8:00 AM, Wolfram Sang <w.sang@pengutronix•de> wrote:
> Initialize the irq-table with PHY_POLL. '-1' means the same now, but is
> hardly maintainable.
>
> Signed-off-by: Wolfram Sang <w.sang@pengutronix•de>
> Cc: Vitaly Bordug <vbordug@ru•mvista.com>
> Cc: Pantelis Antoniou <pantelis.antoniou@gmail•com>
> Cc: Grant Likely <grant.likely@secretlab•ca>
> Cc: netdev@vger•kernel.org
> Cc: linuxppc-dev@ozlabs•org
> ---
> =A0drivers/net/fs_enet/mii-fec.c | =A0 =A02 +-
> =A01 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/fs_enet/mii-fec.c b/drivers/net/fs_enet/mii-fec.=
c
> index 28077cc..9eb5480 100644
> --- a/drivers/net/fs_enet/mii-fec.c
> +++ b/drivers/net/fs_enet/mii-fec.c
> @@ -166,7 +166,7 @@ static int __devinit fs_enet_mdio_probe(struct of_dev=
ice *ofdev,
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0goto out_unmap_regs;
>
> =A0 =A0 =A0 =A0for (i =3D 0; i < PHY_MAX_ADDR; i++)
> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 new_bus->irq[i] =3D -1;
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 new_bus->irq[i] =3D PHY_POLL;
This code no longer exists in net-next.
g.
--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net/fs_enet/mii-fec: Use PHY_POLL instead of hard coded '-1'
2009-05-08 15:55 ` Grant Likely
@ 2009-05-08 16:06 ` Wolfram Sang
0 siblings, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2009-05-08 16:06 UTC (permalink / raw)
To: Grant Likely; +Cc: linuxppc-dev, netdev, Vitaly Bordug
[-- Attachment #1: Type: text/plain, Size: 307 bytes --]
> This code no longer exists in net-next.
EPIC FAIL! :/ I checked the powerpc-tree, but not linux-next. I'm sorry
for the noise, will improve!
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-05-08 16:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-08 14:00 [PATCH] net/fs_enet/mii-fec: Use PHY_POLL instead of hard coded '-1' Wolfram Sang
2009-05-08 15:55 ` Grant Likely
2009-05-08 16:06 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox