From: Wolfram Sang <w.sang@pengutronix•de>
To: Grant Likely <grant.likely@secretlab•ca>
Cc: linuxppc-dev@ozlabs•org
Subject: [PATCH V2] mpc5121/clocks: make debug output more readable
Date: Fri, 15 May 2009 16:40:15 +0200 [thread overview]
Message-ID: <20090515144015.GD3689@pengutronix.de> (raw)
In-Reply-To: <fa686aa40905080840x308c1addld75b1ec5df386c13@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1308 bytes --]
- refactor printk with pr_info/pr_cont
- use '=' in output to connect key/value pairs
Signed-off-by: Wolfram Sang <w.sang@pengutronix•de>
Cc: John Rigby <jcrigby@gmail•com>
Cc: Grant Likely <grant.likely@secretlab•ca>
---
arch/powerpc/platforms/512x/clock.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
Index: arch/powerpc/platforms/512x/clock.c
===================================================================
--- arch/powerpc/platforms/512x/clock.c.orig
+++ arch/powerpc/platforms/512x/clock.c
@@ -83,13 +83,13 @@ static void dump_clocks(void)
mutex_lock(&clocks_mutex);
printk(KERN_INFO "CLOCKS:\n");
list_for_each_entry(p, &clocks, node) {
- printk(KERN_INFO " %s %ld", p->name, p->rate);
+ pr_info(" %s=%ld", p->name, p->rate);
if (p->parent)
- printk(KERN_INFO " %s %ld", p->parent->name,
+ pr_cont(" %s=%ld", p->parent->name,
p->parent->rate);
if (p->flags & CLK_HAS_CTRL)
- printk(KERN_INFO " reg/bit %d/%d", p->reg, p->bit);
- printk("\n");
+ pr_cont(" reg/bit=%d/%d", p->reg, p->bit);
+ pr_cont("\n");
}
mutex_unlock(&clocks_mutex);
}
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
prev parent reply other threads:[~2009-05-15 14:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-08 12:34 [PATCH] mpc5121/clocks: make debug output more readable Wolfram Sang
2009-05-08 14:17 ` Geert Uytterhoeven
2009-05-08 15:40 ` Grant Likely
2009-05-15 14:40 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090515144015.GD3689@pengutronix.de \
--to=w.sang@pengutronix$(echo .)de \
--cc=grant.likely@secretlab$(echo .)ca \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox