From: Mark Brown <broonie@opensource•wolfsonmicro.com>
To: Jon Smirl <jonsmirl@gmail•com>
Cc: linuxppc-dev@ozlabs•org, alsa-devel@alsa-project•org
Subject: Re: [alsa-devel] [PATCH V2 5/9] Main rewite of the mpc5200 audio DMA code
Date: Sun, 24 May 2009 12:26:49 +0100 [thread overview]
Message-ID: <20090524112648.GE4933@sirena.org.uk> (raw)
In-Reply-To: <20090523231305.17919.12239.stgit@terra>
On Sat, May 23, 2009 at 07:13:05PM -0400, Jon Smirl wrote:
This is all basically OK bearing in mind that I know nothing about the
hardware. A couple of things, though:
> +/* ---------------------------------------------------------------------
> + * Sysfs attributes for debugging
> + */
These look like they may be better placed in debugfs?
> +EXPORT_SYMBOL_GPL(mpc5200_audio_dma_create);
> +EXPORT_SYMBOL_GPL(mpc5200_audio_dma_destroy);
> +static int __init mpc5200_soc_platform_init(void)
> +{
> + /* Tell the ASoC OF helpers about it */
> + return snd_soc_register_platform(&mpc5200_audio_dma_platform);
> +}
> +module_init(mpc5200_soc_platform_init);
> +static void __exit mpc5200_soc_platform_exit(void)
> +{
> + snd_soc_unregister_platform(&mpc5200_audio_dma_platform);
> +}
> +module_exit(mpc5200_soc_platform_exit);
This all looks a bit odd - I'd expect to see the platform registering
with the core when it is probed rather than on module load. Looking at
the code it appears that you're automatically instantiating the DMA
driver from the node for the DAI? If that is the case then you ought
to be calling the platform registration functions from the dma_create()
and dma_destroy() functions instead.
next prev parent reply other threads:[~2009-05-24 11:27 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-23 23:12 [PATCH V2 0/9] mpc5200 audio rework for AC97 Jon Smirl
2009-05-23 23:12 ` [PATCH V2 1/9] Register the wm9712 DAIs on module load Jon Smirl
2009-05-24 11:11 ` [alsa-devel] " Mark Brown
2009-05-24 15:28 ` Jon Smirl
2009-05-24 15:32 ` Jon Smirl
2009-05-24 19:14 ` Mark Brown
2009-05-23 23:12 ` [PATCH V2 2/9] Basic split of mpc5200 DMA code out from mpc5200_psc_i2s Jon Smirl
2009-05-24 14:11 ` Grant Likely
2009-05-23 23:13 ` [PATCH V2 3/9] Rename the PSC functions to DMA Jon Smirl
2009-05-24 11:15 ` [alsa-devel] " Mark Brown
2009-05-24 14:12 ` Grant Likely
2009-05-23 23:13 ` [PATCH V2 4/9] Add a few more mpc5200 PSC defines Jon Smirl
2009-05-24 14:13 ` Grant Likely
2009-05-24 18:00 ` Mark Brown
2009-05-24 18:19 ` Grant Likely
2009-05-24 18:32 ` [alsa-devel] " Mark Brown
2009-05-23 23:13 ` [PATCH V2 5/9] Main rewite of the mpc5200 audio DMA code Jon Smirl
2009-05-24 11:26 ` Mark Brown [this message]
2009-05-24 18:55 ` Wolfram Sang
2009-05-24 20:10 ` Jon Smirl
2009-05-24 20:35 ` Wolfram Sang
2009-05-25 7:56 ` Juergen Beisert
2009-05-25 10:51 ` Mark Brown
2009-05-23 23:13 ` [PATCH V2 6/9] Codec for STAC9766 used on the Efika Jon Smirl
2009-05-24 11:46 ` [alsa-devel] " Mark Brown
2009-05-23 23:13 ` [PATCH V2 7/9] AC97 driver for mpc5200 Jon Smirl
2009-05-24 12:10 ` [alsa-devel] " Mark Brown
2009-05-23 23:13 ` [PATCH V2 8/9] Fabric bindings for STAC9766 on the Efika Jon Smirl
2009-05-24 12:12 ` [alsa-devel] " Mark Brown
2009-05-23 23:13 ` [PATCH V2 9/9] Support for AC97 on Phytec pmc030 base board Jon Smirl
2009-05-24 12:13 ` [alsa-devel] " Mark Brown
2009-05-23 23:20 ` [PATCH V2 0/9] mpc5200 audio rework for AC97 Jon Smirl
2009-05-24 11:08 ` [alsa-devel] " Mark Brown
2009-05-24 15:21 ` Jon Smirl
2009-05-24 18:35 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090524112648.GE4933@sirena.org.uk \
--to=broonie@opensource$(echo .)wolfsonmicro.com \
--cc=alsa-devel@alsa-project$(echo .)org \
--cc=jonsmirl@gmail$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox