From: Arnd Bergmann <arnd@arndb•de>
To: linuxppc-dev@ozlabs•org
Cc: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom•com>,
alsa-devel@alsa-project•org, Timur Tabi <timur@freescale•com>,
broonie@sirena•org.uk
Subject: Re: [PATCH V4 1/5] The macro spin_event_timeout() takes a condition and timeout value
Date: Tue, 26 May 2009 13:49:48 +0100 [thread overview]
Message-ID: <200905261349.49832.arnd@arndb.de> (raw)
In-Reply-To: <alpine.LRH.2.00.0905261348160.4897@vixen.sonytel.be>
On Tuesday 26 May 2009, Geert Uytterhoeven wrote:
> However, you can still improve useability by making the macro return the rc,
> instead of letting the caller pass it, cfr. wait_event_timeout() and friends.
Either that, or it should at least use the do { ... } while (0) construct
to make the macro a statement. All multi-line macros need to either
use ({ ... }) or do { ... } while (0) to make sure they behave well.
Arnd <><
next prev parent reply other threads:[~2009-05-26 12:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-25 22:15 [PATCH V4 0/5] AC97 driver for mpc5200 Jon Smirl
2009-05-25 22:15 ` [PATCH V4 1/5] The macro spin_event_timeout() takes a condition and timeout value Jon Smirl
2009-05-26 7:29 ` Geert Uytterhoeven
2009-05-26 11:32 ` Timur Tabi
2009-05-26 11:51 ` Geert Uytterhoeven
2009-05-26 12:49 ` Arnd Bergmann [this message]
2009-05-26 14:20 ` Timur Tabi
2009-05-25 22:15 ` [PATCH V4 2/5] Main rewite of the mpc5200 audio DMA code Jon Smirl
2009-05-26 11:01 ` [alsa-devel] " Mark Brown
2009-05-26 16:51 ` Grant Likely
2009-05-26 16:53 ` Jon Smirl
2009-05-26 16:56 ` Grant Likely
2009-05-26 17:08 ` Timur Tabi
2009-05-26 20:21 ` Mark Brown
2009-05-25 22:15 ` [PATCH V4 3/5] AC97 driver for mpc5200 Jon Smirl
2009-05-26 3:41 ` [alsa-devel] " Timur Tabi
2009-05-26 3:47 ` Grant Likely
2009-05-25 22:15 ` [PATCH V4 4/5] Support for AC97 on Phytec pmc030 base board Jon Smirl
2009-05-25 22:15 ` [PATCH V4 5/5] Fabric bindings for STAC9766 on the Efika Jon Smirl
2009-05-26 3:44 ` [alsa-devel] [PATCH V4 0/5] AC97 driver for mpc5200 Timur Tabi
2009-05-26 9:21 ` Mark Brown
2009-05-26 11:08 ` Jon Smirl
2009-05-26 11:39 ` Timur Tabi
2009-05-26 11:43 ` Mark Brown
2009-05-26 11:04 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905261349.49832.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=Geert.Uytterhoeven@sonycom$(echo .)com \
--cc=alsa-devel@alsa-project$(echo .)org \
--cc=broonie@sirena$(echo .)org.uk \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=timur@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox