Subject: Re: [PATCH 10/33] powerpc/cell: Extract duplicated IOPTE_* to <asm/iommu.h>

From: Arnd Bergmann <[email-masked]>
Date: Mon, 15 Jun 2009 09:05:29 +0200

On Monday 15 June 2009, Benjamin Herrenschmidt wrote:
> On Wed, 2009-06-10 at 16:38 +0200, Geert Uytterhoeven wrote:
> > Both arch/powerpc/platforms/cell/iommu.c and arch/powerpc/platforms/ps3/mm.c
> > contain the same Cell IOMMU page table entry definitions. Extract them and move
> > them to <asm/iommu.h>, while adding a CBE_ prefix.
> > This also allows them to be used by drivers.
> 
> Are we sure include/asm/iommu.h is the right place for that ?
> 
> I'm hesitating here...

Good point, that file does not contain hardware specific definitions but
only interfaces.

Geert, how about putting them into arch/powerpc/include/asm/cell-regs.h
instead?

	Arnd <><