Subject: Re: [PATCH] Do not inline putprops function

From: "M. Mohan Kumar" <[email-masked]>
Date: Wed, 17 Jun 2009 19:04:35 +0530

On Wed, Jun 17, 2009 at 09:04:13AM -0400, Neil Horman wrote:
> On Wed, Jun 17, 2009 at 10:26:35PM +1000, Michael Ellerman wrote:
> > 
> > What compiler version are you using? Does the behaviour change if you
> > use a newer/older compiler? It sounds to me like there's some deeper bug
> > and your patch is just papering over it.
> > 

I tried with gcc 4.3.2. Let me try with a recent version and update.

> Agreed, this doesn't make any sense. Try changing the compiler version to see if
> the problem goes away or stops.  It might also be worthwhile to dump the
> contents of the device tree at the start and end of the kexec process.  If the
> changing of how a function is inlined is causing a hang, its likely changing how
> the putprops function is writing information to the device tree.  Understanding
> what that change is will likely provide clues to how the code has changed.

Neil, there was no code change in fs2dt.c

Regards,
M. Mohan Kumar