Subject: Re: Subject: [PATCH v8] spi: Add PPC4xx SPI driver

From: David Brownell <[email-masked]>
Date: Thu, 2 Jul 2009 17:44:27 -0700

On Friday 26 June 2009, Steven A. Falco wrote:
> +
> +       /*
> +        * If there are no chip selects at all, or if this is the special
> +        * case of a non-existent (dummy) chip select, do nothing.
> +        */
> +
> +       if (!hw->master->num_chipselect || hw->gpios[cs] == -EEXIST)
> +               return;
> +

I'm going to send this in, but please send a followup
patch making all this "non-existent (dummy) chip select"
stuff use the SPI_NO_CS flag.

> +       /*
> +        * A count of zero implies a single SPI device without any chip-select.
> +        * Note that of_gpio_count counts all gpios assigned to this spi master.
> +        * This includes both "null" gpio's and real ones.
> +        */