From: Mark Nelson <markn@au1•ibm.com>
To: linuxppc-dev@lists•ozlabs.org
Cc: "Kári Davíðsson" <kari.davidsson@marel•com>,
"Kumar Gala" <galak@gate•crashing.org>,
"linuxppc-dev@ozlabs•org" <linuxppc-dev@ozlabs•org>
Subject: Re: dma_ops->map_page == NULL
Date: Wed, 8 Jul 2009 10:44:58 +1000 [thread overview]
Message-ID: <200907081044.59115.markn@au1.ibm.com> (raw)
In-Reply-To: <1246964905.6066.41.camel@pasglop>
On Tuesday 07 July 2009 21:08:25 Benjamin Herrenschmidt wrote:
> On Tue, 2009-07-07 at 10:15 +1000, Mark Nelson wrote:
> >
> > When the 32 and 64bit DMA code was merged in .28 , map_/unmap_page() was
> > added in favour of map_/unmap_single() (which was later removed in .29)
> > so you'll have to replace your calls to dma_map_single() with
> > dma_map_page(). Just pass it the page and offset rather than the address.
>
> Wait a minute ... dma_map_single() should still work, it will just call
> dma_map_page() underneath. All dma_ops should have a ->map page
> callback.
Sorry my mistake - I was thinking of when we removed the map/unmap_single()
from the dma_mapping_ops.
Mark.
next prev parent reply other threads:[~2009-07-08 0:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-06 17:51 dma_ops->map_page == NULL Kári Davíðsson
2009-07-07 0:15 ` Mark Nelson
2009-07-07 11:08 ` Benjamin Herrenschmidt
2009-07-07 14:37 ` Kumar Gala
2009-07-07 15:24 ` Kári Davíðsson
2009-07-07 15:45 ` Kumar Gala
2009-07-07 15:49 ` Becky Bruce
2009-07-08 0:44 ` Mark Nelson [this message]
2009-07-07 12:50 ` Jon Smirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907081044.59115.markn@au1.ibm.com \
--to=markn@au1$(echo .)ibm.com \
--cc=galak@gate$(echo .)crashing.org \
--cc=kari.davidsson@marel$(echo .)com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox