From: "Gerhard Pircher" <gerhard_pircher@gmx•net>
To: Takashi Iwai <tiwai@suse•de>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: ALSA fixes for non-coherent ppc32 again
Date: Thu, 09 Jul 2009 13:22:38 +0200 [thread overview]
Message-ID: <20090709112238.34100@gmx.net> (raw)
In-Reply-To: <s5hfxd7qn49.wl%tiwai@suse.de>
-------- Original-Nachricht --------
> Datum: Wed, 08 Jul 2009 16:13:10 +0200
> Von: Takashi Iwai <tiwai@suse•de>
> An: Benjamin Herrenschmidt <benh@kernel•crashing.org>
> CC: Gerhard Pircher <gerhard_pircher@gmx•net>, linuxppc-dev@ozlabs•org
> Betreff: Re: ALSA fixes for non-coherent ppc32 again
> At Wed, 08 Jul 2009 13:01:50 +1000,
> Benjamin Herrenschmidt wrote:
> >
> > On Mon, 2009-06-22 at 08:34 +1000, Benjamin Herrenschmidt wrote:
> > > On Sun, 2009-06-21 at 20:18 +0200, Gerhard Pircher wrote:
> > > > Hi,
> > > >
> > > > Takashi Iwai posted patches to make ALSA work on non-coherent
> > > > PPC32 systems (almost exactly) a year ago. See here:
> > > >
> > > > http://www.nabble.com/-PATCH-0-3--ALSA-fixes-for-non-coherent-ppc32-to17980027.html#a17980027
> > > >
> > > > As far as I can see these patches never went upstream. Where
> > > > there any objections or did we just forget about them? It would
> > > > be cool, if the patches could be merged now, as at least two
> > > > platforms need this bugfix (namely Sam440 and AmigaOne).
> > >
> > > I definitely forgot about those... But I'm fine with what Takashi
> > > did for now, I can always make the powerpc helper for
> > > dma_mmap_coherent() smarter later on if necessary.
> >
> > BTW. Can you guys send a "final" patch for adding mmap_coherent to
> > powerpc ? Please make so that the dma_mmap_coherent() function doesn't
> > explose if dma_ops->mmap_coherent is NULL though (either fail
> > gracefully or fallback to some standard mmap).
>
> The attached is the revised patch. It falls backs to the standard
> mmap.
>
> The whole patch series are found in test/dma-fix branch of sound git
> tree below:
> git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6.git
> test/dma-fix
>
> I had no time to play cross-build yet, so it'd be helpful if someone
> can test it...
> (BTW, any good minimal gcc and binutils package for kernel builds for
> PPC32?)
Okay, I cross-build it on a x86 machine and tested it on my AmigaOne with
the VIA686 onboard sound and a Soundblaster 5.1. It worked fine after I
applied the "ALSA: Fix SG-buffer DMA with non-coherent architectures"
patch.
Thanks!
Gerhard
--
Neu: GMX Doppel-FLAT mit Internet-Flatrate + Telefon-Flatrate
für nur 19,99 Euro/mtl.!* http://portal.gmx.net/de/go/dsl02
prev parent reply other threads:[~2009-07-09 11:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-21 18:18 ALSA fixes for non-coherent ppc32 again Gerhard Pircher
2009-06-21 22:34 ` Benjamin Herrenschmidt
2009-06-22 7:12 ` Takashi Iwai
2009-06-22 9:23 ` Gerhard Pircher
2009-06-23 8:55 ` Gerhard Pircher
2009-06-23 21:42 ` Gerhard Pircher
2009-06-24 8:46 ` Gerhard Pircher
2009-06-24 9:47 ` Takashi Iwai
2009-06-26 13:14 ` Gerhard Pircher
2009-07-08 14:14 ` Takashi Iwai
2009-07-08 3:01 ` Benjamin Herrenschmidt
2009-07-08 14:13 ` Takashi Iwai
2009-07-09 11:22 ` Gerhard Pircher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090709112238.34100@gmx.net \
--to=gerhard_pircher@gmx$(echo .)net \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=tiwai@suse$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox