From: Sebastian Andrzej Siewior <bigeasy@linutronix•de>
To: Pantelis Antoniou <pantelis.antoniou@gmail•com>,
Vitaly Bordug <vbordug@ru•mvista.com>
Cc: linuxppc-dev@ozlabs•org, netdev@vger•kernel.org
Subject: [RFC] net/fs_enet: send a reset request to the PHY on init
Date: Wed, 2 Sep 2009 13:04:10 +0200 [thread overview]
Message-ID: <20090902110410.GC15401@www.tglx.de> (raw)
Usually u-boot sends a phy request in its network init routine. An uboot
without network support doesn't do it and I endup without working
network. I still can switch between 10/100Mbit (according to the LED on
the hub and phy registers) but I can't send or receive any data.
At this point I'm not sure if the PowerON Reset takes the PHY a few
nsecs too early out of reset or if this reset is required and everyone
relies on U-boot performing this reset.
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix•de>
---
This is done on a custom mpc512x board. Unfortunately I don't have other
boards to check. The PHY is a AMD Am79C874, phylib uses the generic one.
drivers/net/fs_enet/fs_enet-main.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/net/fs_enet/fs_enet-main.c b/drivers/net/fs_enet/fs_enet-main.c
index ee15402..a3c962b 100644
--- a/drivers/net/fs_enet/fs_enet-main.c
+++ b/drivers/net/fs_enet/fs_enet-main.c
@@ -823,7 +823,8 @@ static int fs_init_phy(struct net_device *dev)
}
fep->phydev = phydev;
-
+ phy_write(phydev, MII_BMCR, BMCR_RESET);
+ udelay(1);
return 0;
}
--
1.6.4.GIT
next reply other threads:[~2009-09-02 11:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-02 11:04 Sebastian Andrzej Siewior [this message]
2009-09-03 16:48 ` [RFC] net/fs_enet: send a reset request to the PHY on init Grant Likely
2009-09-04 15:38 ` Sebastian Andrzej Siewior
2009-09-04 15:45 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090902110410.GC15401@www.tglx.de \
--to=bigeasy@linutronix$(echo .)de \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pantelis.antoniou@gmail$(echo .)com \
--cc=vbordug@ru$(echo .)mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox