From: Julie Zhu <julie.zhu@xilinx•com>
To: "Grant Likely" <grant.likely@secretlab•ca>
Cc: linux-usb@vger•kernel.org, gregkh@suse•de,
linuxppc-dev@ozlabs•org, John Linn <linnj@xilinx•com>
Subject: RE: [PATCH] USB: Add support for Xilinx USB host controller
Date: Mon, 21 Sep 2009 08:41:47 -0600 [thread overview]
Message-ID: <20090921144131.1C1A31078051@mail56-sin.bigfish.com> (raw)
In-Reply-To: <fa686aa40909210714j428aa524qacc7a83f40db411b@mail.gmail.com>
Thanks, Grant and Ben,
> > Add bus glue driver for Xilinx USB host controller. The controller can
> be
> > configured as HS only or HS/FS hybrid. The driver uses the device tree
> file
> > to configure the driver according to the setting in the hardware system=
.
> >
> > This driver has been tested with usbtest using the NET2280 PCI card.
> >
> > Signed-off-by: Julie Zhu <julie.zhu@xilinx•com>
> =
> As Ben said, this is nice tight code. Two comments below.
> =
> > +/**
> > + * ehci_xilinx_port_handed_over - hand the port out if failed to enabl=
e
> it
> > + * @hcd: =A0 =A0 =A0 Pointer to the usb_hcd device to which the host
> controller bound
> > + * @portnum:Port number to which the device is attached.
> > + *
> > + * This function is used as a place to tell the user that the Xilinx
> USB host
> > + * controller does support LS devices. And in an HS only configuration=
,
> it
> > + * does not support FS devices neither. It is hoped that this can help=
> a
> =
> s/neither/either
> =
> [...]
> > +static struct of_device_id ehci_hcd_xilinx_of_match[] =3D {
> > + =A0 =A0 =A0 {
> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 .compatible =3D "usb-ehci",
> > + =A0 =A0 =A0 },
> =
> This looks wrong. Since this driver only works with Xilinx USB
> controllers,
> it should be binding against "xlnx,xps-usb-host-1.00.a", and the meaning
> of
> that binding needs to be documented in Documentation/powerpc/dts-bindings=
.
> =
I have changed the compatible to "xlnx,xps-usb-host-1.00.a", thanks for cat=
ching this.
Where should I put the binding for Xilinx USB host controller? usb-ehci.txt=
or xilinx.txt?
Thanks,
Julie.
> Having this driver bind against the generic "usb-ehci" will cause
> conflicts
> with the ehci-ppc-of driver.
> =
> Cheers,
> g.
> =
> --
> Grant Likely, B.Sc., P.Eng.
> Secret Lab Technologies Ltd.
This email and any attachments are intended for the sole use of the named r=
ecipient(s) and contain(s) confidential information that may be proprietary=
, privileged or copyrighted under applicable law. If you are not the intend=
ed recipient, do not read, copy, or forward this email message or any attac=
hments. Delete this email message and any attachments immediately.
next prev parent reply other threads:[~2009-09-21 14:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-15 22:10 [PATCH] USB: Add support for Xilinx USB host controller Julie Zhu
2009-09-21 10:23 ` Benjamin Herrenschmidt
2009-09-21 14:14 ` Grant Likely
2009-09-21 14:41 ` Julie Zhu [this message]
2009-09-21 14:46 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090921144131.1C1A31078051@mail56-sin.bigfish.com \
--to=julie.zhu@xilinx$(echo .)com \
--cc=grant.likely@secretlab$(echo .)ca \
--cc=gregkh@suse$(echo .)de \
--cc=linnj@xilinx$(echo .)com \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox