From: Anton Vorontsov <avorontsov@ru•mvista.com>
To: Greg Kroah-Hartman <gregkh@suse•de>
Cc: Jerry Huang <Chang-Ming.Huang@freescale•com>,
linux-usb@vger•kernel.org, linuxppc-dev@ozlabs•org,
Scott Wood <scottwood@freescale•com>
Subject: [PATCH 2/3] USB: ehci-fsl: Fix sparse warnings
Date: Wed, 23 Sep 2009 22:52:42 +0400 [thread overview]
Message-ID: <20090923185242.GB18755@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <20090923185158.GA29065@oksana.dev.rtsoft.ru>
This patch fixes following warnings:
ehci-fsl.c:43:5: warning: symbol 'usb_hcd_fsl_probe' was not declared. Should it be static?
ehci-fsl.c:150:6: warning: symbol 'usb_hcd_fsl_remove' was not declared. Should it be static?
Signed-off-by: Anton Vorontsov <avorontsov@ru•mvista.com>
---
drivers/usb/host/ehci-fsl.c | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c
index 9911749..593a7e7 100644
--- a/drivers/usb/host/ehci-fsl.c
+++ b/drivers/usb/host/ehci-fsl.c
@@ -40,8 +40,8 @@
* Allocates basic resources for this USB host controller.
*
*/
-int usb_hcd_fsl_probe(const struct hc_driver *driver,
- struct platform_device *pdev)
+static int usb_hcd_fsl_probe(const struct hc_driver *driver,
+ struct platform_device *pdev)
{
struct fsl_usb2_platform_data *pdata;
struct usb_hcd *hcd;
@@ -147,7 +147,8 @@ int usb_hcd_fsl_probe(const struct hc_driver *driver,
* Reverses the effect of usb_hcd_fsl_probe().
*
*/
-void usb_hcd_fsl_remove(struct usb_hcd *hcd, struct platform_device *pdev)
+static void usb_hcd_fsl_remove(struct usb_hcd *hcd,
+ struct platform_device *pdev)
{
usb_remove_hcd(hcd);
iounmap(hcd->regs);
--
1.6.3.3
next prev parent reply other threads:[~2009-09-23 18:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-23 18:51 [PATCH 0/3] USB: ehci-fsl: Resume from deep sleep Anton Vorontsov
2009-09-23 18:52 ` [PATCH 1/3] powerpc/fsl: Make fsl_deep_sleep() usable w/ modules and non-83xx builds Anton Vorontsov
2009-11-05 14:58 ` Kumar Gala
2009-09-23 18:52 ` Anton Vorontsov [this message]
2009-09-23 18:52 ` [PATCH 3/3] USB: ehci-fsl: Add power management support (resume after deep sleep) Anton Vorontsov
2009-09-25 2:30 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090923185242.GB18755@oksana.dev.rtsoft.ru \
--to=avorontsov@ru$(echo .)mvista.com \
--cc=Chang-Ming.Huang@freescale$(echo .)com \
--cc=gregkh@suse$(echo .)de \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=scottwood@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox