* [PATCH] powerpc: warning: allocated section `.data_nosave' not in segment
@ 2009-09-29 16:00 Sean MacLennan
2009-09-29 20:40 ` Segher Boessenkool
0 siblings, 1 reply; 2+ messages in thread
From: Sean MacLennan @ 2009-09-29 16:00 UTC (permalink / raw)
To: linuxppc-dev
We need to align before the output section. Having the align inside
the output section causes the linker to put some filler in there,
which makes it a non-empty section, but this section isn't assigned to
a segment so you get a warning from the linker.
Signed-off-by: Sean MacLennan <smaclennan@pikatech•com>
---
diff --git a/arch/powerpc/kernel/vmlinux.lds.S
b/arch/powerpc/kernel/vmlinux.lds.S index f564293..e853763 100644
--- a/arch/powerpc/kernel/vmlinux.lds.S
+++ b/arch/powerpc/kernel/vmlinux.lds.S
@@ -236,6 +236,7 @@ SECTIONS
READ_MOSTLY_DATA(L1_CACHE_BYTES)
}
+ . = ALIGN(PAGE_SIZE);
.data_nosave : AT(ADDR(.data_nosave) - LOAD_OFFSET) {
NOSAVE_DATA
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] powerpc: warning: allocated section `.data_nosave' not in segment
2009-09-29 16:00 [PATCH] powerpc: warning: allocated section `.data_nosave' not in segment Sean MacLennan
@ 2009-09-29 20:40 ` Segher Boessenkool
0 siblings, 0 replies; 2+ messages in thread
From: Segher Boessenkool @ 2009-09-29 20:40 UTC (permalink / raw)
To: Sean MacLennan; +Cc: linuxppc-dev
> We need to align before the output section. Having the align inside
> the output section causes the linker to put some filler in there,
> which makes it a non-empty section, but this section isn't assigned to
> a segment so you get a warning from the linker.
>
> Signed-off-by: Sean MacLennan <smaclennan@pikatech•com>
> ---
> diff --git a/arch/powerpc/kernel/vmlinux.lds.S
> b/arch/powerpc/kernel/vmlinux.lds.S index f564293..e853763 100644
> --- a/arch/powerpc/kernel/vmlinux.lds.S
> +++ b/arch/powerpc/kernel/vmlinux.lds.S
> @@ -236,6 +236,7 @@ SECTIONS
> READ_MOSTLY_DATA(L1_CACHE_BYTES)
> }
>
> + . = ALIGN(PAGE_SIZE);
> .data_nosave : AT(ADDR(.data_nosave) - LOAD_OFFSET) {
> NOSAVE_DATA
> }
Acked-by: Segher Boessenkool <segher@kernel•crashing.org>
The patch is good and fixes a real problem. But, I still don't see how
it caused the "warning: allocated section `.data_nosave' not in
segment",
it would be good if we can find out.
Segher
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-09-29 20:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-29 16:00 [PATCH] powerpc: warning: allocated section `.data_nosave' not in segment Sean MacLennan
2009-09-29 20:40 ` Segher Boessenkool
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox