Subject: Re: [PATCH v2] mpc5200: support for the MAN mpc5200 based board uc101

From: Wolfram Sang <[email-masked]>
Date: Mon, 5 Oct 2009 11:53:40 +0200

On Mon, Oct 05, 2009 at 09:46:43AM +0200, Heiko Schocher wrote:

> - serial Console on PSC1
> - 64MB SDRAM
> - MTD CFI Flash
> - Ethernet FEC
> - IDE support
> 
> Signed-off-by: Heiko Schocher <[email-masked]>
> ---
> - based on:
>   git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc.git next
> 
> - checked with:
> $ ./scripts/checkpatch.pl 0001-mpc5200-support-for-the-MAN-mpc5200-based-board-uc1.patch
> total: 0 errors, 0 warnings, 324 lines checked
> 
> 0001-mpc5200-support-for-the-MAN-mpc5200-based-board-uc1.patch has no obvious style problems and is ready for submission.
> $
> 
> changes since v1:
> 
> - add comments from Grant Likely <[email-masked]>
>   use mpc5200_defconfig as default configuration
> - add comments from Wolfram Sang <[email-masked]>
> - rebase against current next
> 
>  arch/powerpc/boot/dts/uc101.dts              |  317 ++++++++++++++++++++++++++
>  arch/powerpc/platforms/52xx/mpc5200_simple.c |    1 +
>  2 files changed, 318 insertions(+), 0 deletions(-)
>  create mode 100644 arch/powerpc/boot/dts/uc101.dts
> 
[...]
> +		wdt {
> +			compatible = "generic,gpio-wdt";
> +			reg = <0x600 0x10>;
> +			gpios = <&gpt0 0 0>;
> +			period = <500>;	// WDT trigger period in msec
> +		};

Is this an official binding? I also did an gpio-watchdog a while ago and there
were some issues with the binding, IIRC. Would be nice if this has been solved
meanwhile.

Other than that, it looks okay to me.

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |