From: David Miller <davem@davemloft•net>
To: grant.likely@secretlab•ca
Cc: sfr@canb•auug.org.au, monstr@monstr•eu,
microblaze-uclinux@itee•uq.edu.au,
devicetree-discuss@lists•ozlabs.org, sparclinux@vger•kernel.org,
linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH v2 11/11] of: unify phandle name in struct device_node
Date: Tue, 24 Nov 2009 14:22:42 -0800 (PST) [thread overview]
Message-ID: <20091124.142242.46843869.davem@davemloft.net> (raw)
In-Reply-To: <20091124215908.559.23998.stgit@angua>
From: Grant Likely <grant.likely@secretlab•ca>
Date: Tue, 24 Nov 2009 15:01:14 -0700
> In struct device_node, the phandle is named 'linux_phandle' for PowerPC
> and MicroBlaze, and 'node' for SPARC. There is no good reason for the
> difference, it is just an artifact of the code diverging over a couple
> of years. This patch renames both to simply .phandle.
>
> Note: the .node also existed in PowerPC/MicroBlaze, but the only user
> seems to be arch/powerpc/platforms/powermac/pfunc_core.c. It doesn't
> look like the assignment between .linux_phandle and .node is
> significantly different enough to warrant the separate code paths
> unless ibm,phandle properties actually appear in Apple device trees.
>
> I think it is safe to eliminate the old .node property and use
> linux_phandle everywhere.
>
> Signed-off-by: Grant Likely <grant.likely@secretlab•ca>
Acked-by: David S. Miller <davem@davemloft•net>
next prev parent reply other threads:[~2009-11-24 22:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-24 22:01 [PATCH v2 11/11] of: unify phandle name in struct device_node Grant Likely
2009-11-24 22:22 ` David Miller [this message]
2009-11-25 1:30 ` Segher Boessenkool
2009-11-25 1:33 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091124.142242.46843869.davem@davemloft.net \
--to=davem@davemloft$(echo .)net \
--cc=devicetree-discuss@lists$(echo .)ozlabs.org \
--cc=grant.likely@secretlab$(echo .)ca \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=microblaze-uclinux@itee$(echo .)uq.edu.au \
--cc=monstr@monstr$(echo .)eu \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=sparclinux@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox