From: Bartlomiej Zolnierkiewicz <bzolnier@gmail•com>
To: "Robert P. J. Day" <rpjday@crashcourse•ca>
Cc: Joe Perches <joe@perches•com>,
linuxppc-dev@ozlabs•org,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>
Subject: Re: [PATCH] HVSI: Fix apparently backwards args to time_before() in hvsi.c
Date: Fri, 1 Jan 2010 19:15:47 +0100 [thread overview]
Message-ID: <201001011915.47849.bzolnier@gmail.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1001011226020.24958@localhost>
On Friday 01 January 2010 06:28:03 pm Robert P. J. Day wrote:
>
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse•ca>
>
> ---
>
> no appropriate subsystem maintainer listed in MAINTAINERS.
drivers/char/Makefile:
obj-$(CONFIG_HVC_CONSOLE) += hvc_vio.o hvsi.o
so it should belong to:
HYPERVISOR VIRTUAL CONSOLE DRIVER
L: linuxppc-dev@ozlabs•org
S: Odd Fixes
F: drivers/char/hvc_*
[ Though maybe Ben would be willing to pick this one up directly
as hvsi is PPC specific thingy and patch is obviously correct. ]
> diff --git a/drivers/char/hvsi.c b/drivers/char/hvsi.c
> index 793b236..71c0fcd 100644
> --- a/drivers/char/hvsi.c
> +++ b/drivers/char/hvsi.c
> @@ -711,7 +711,7 @@ static void hvsi_drain_input(struct hvsi_struct *hp)
> uint8_t buf[HVSI_MAX_READ] __ALIGNED__;
> unsigned long end_jiffies = jiffies + HVSI_TIMEOUT;
>
> - while (time_before(end_jiffies, jiffies))
> + while (time_before(jiffies, end_jiffies))
> if (0 == hvsi_read(hp, buf, HVSI_MAX_READ))
> break;
> }
--
Bartlomiej Zolnierkiewicz
next parent reply other threads:[~2010-01-01 18:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.LFD.2.00.1001011226020.24958@localhost>
2010-01-01 18:15 ` Bartlomiej Zolnierkiewicz [this message]
2010-01-01 21:11 ` [PATCH] HVSI: Fix apparently backwards args to time_before() in hvsi.c Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001011915.47849.bzolnier@gmail.com \
--to=bzolnier@gmail$(echo .)com \
--cc=joe@perches$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=rpjday@crashcourse$(echo .)ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox