From: Matthew Wilcox <matthew@wil•cx>
To: Benjamin Herrenschmidt <benh@kernel•crashing.org>
Cc: Linux PCI <linux-pci@vger•kernel.org>,
Jay Vosburgh <fubar@us•ibm.com>,
Jesse Barnes <jbarnes@virtuousgeek•org>,
David Miller <davem@davemloft•net>,
Ron Mercer <ron.mercer@qlogic•com>,
kaneshige.kenji@jp•fujitsu.com, linuxppc-dev@lists•ozlabs.org,
Breno Leitao <leitao@linux•vnet.ibm.com>
Subject: Re: [RFC PATCH] PCI-E broken on PPC (regression)
Date: Thu, 28 Jan 2010 20:45:24 -0700 [thread overview]
Message-ID: <20100129034524.GA13385@parisc-linux.org> (raw)
In-Reply-To: <1264558256.3601.153.camel@pasglop>
On Wed, Jan 27, 2010 at 01:10:56PM +1100, Benjamin Herrenschmidt wrote:
>
> > Cc'ing Ben for PPC. Ben, should PPC use pci_scan_device when probing
> > its root busses? Sounds like it just uses pci_device_add for each one
> > it finds instead?
> >
> > If you don't actually need scanning (though what about hotplug?) we can
> > move the call to device_add instead...
>
> Ok so I looked at the code and the problem goes way beyond root busses.
>
> Basically, powerpc can use the code in arch/powerpc/kernel/pci_of_scan.c
> to "generate" the pci_dev without using config space probing or at least
> using as little of it as possible, using the firmware device-tree
> information instead.
>
> This is also probably going to be moved to a more generic place and
> extended to be used optionally by other architectures.
Yes, having it under drivers/pci/ somewhere would be a big improvement,
that way we'd actually see it when trying to do cleanups and wouldn't
accidentally break your architectures.
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2010-01-29 3:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-25 13:42 [RFC PATCH] PCI-E broken on PPC (regression) Breno Leitao
2010-01-25 20:38 ` Jesse Barnes
2010-01-26 1:50 ` Jesse Barnes
2010-01-26 2:59 ` Benjamin Herrenschmidt
2010-01-26 4:36 ` Kenji Kaneshige
2010-01-27 2:10 ` Benjamin Herrenschmidt
2010-01-27 16:26 ` Jesse Barnes
2010-01-27 22:00 ` Benjamin Herrenschmidt
2010-01-28 0:01 ` David Miller
2010-01-28 0:03 ` Jesse Barnes
2010-01-29 3:45 ` Matthew Wilcox [this message]
2010-01-29 3:54 ` Benjamin Herrenschmidt
2010-02-18 0:22 ` David Miller
2010-02-18 0:29 ` Jesse Barnes
2010-01-26 4:18 ` Kenji Kaneshige
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100129034524.GA13385@parisc-linux.org \
--to=matthew@wil$(echo .)cx \
--cc=benh@kernel$(echo .)crashing.org \
--cc=davem@davemloft$(echo .)net \
--cc=fubar@us$(echo .)ibm.com \
--cc=jbarnes@virtuousgeek$(echo .)org \
--cc=kaneshige.kenji@jp$(echo .)fujitsu.com \
--cc=leitao@linux$(echo .)vnet.ibm.com \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=ron.mercer@qlogic$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox