From: Jason Gunthorpe <jgunthorpe@obsidianresearch•com>
To: Rajiv Andrade <srajiv@linux•vnet.ibm.com>
Cc: linuxppc-dev@ozlabs•org, tpmdd-devel@lists•sourceforge.net,
linux-kernel@vger•kernel.org
Subject: Re: [tpmdd-devel] [PATCH] TPM: Provide a tpm_tis OF driver
Date: Wed, 24 Mar 2010 23:23:28 -0600 [thread overview]
Message-ID: <20100325052328.GB9769@obsidianresearch.com> (raw)
In-Reply-To: <1269490841.12676.32.camel@blackbox.ibm.com>
On Thu, Mar 25, 2010 at 01:20:41AM -0300, Rajiv Andrade wrote:
> Why not
>
> +#ifdef CONFIG_OF
> + return of_register_platform_driver(&tis_of_driver);
> +#elif CONFIG_PNP
> + return pnp_register_driver(&tis_pnp_driver);
> +#endif
>
> ?
AFAIK they are not exclusive options? I can't imagine anyone building
a kernel with both, but the rest of the patch is designed to allow
both at once..
> Acked-by: Rajiv Andrade <srajiv@linux•vnet.ibm.com>
Thanks - who can pick this up to feed it upstream?
Jason
prev parent reply other threads:[~2010-03-25 5:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-09 20:01 [PATCH] TPM: Provide a tpm_tis OF driver Jason Gunthorpe
2010-03-25 4:20 ` [tpmdd-devel] " Rajiv Andrade
2010-03-25 5:23 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100325052328.GB9769@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=srajiv@linux$(echo .)vnet.ibm.com \
--cc=tpmdd-devel@lists$(echo .)sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox