From: Mark Nelson <markn@au1•ibm.com>
To: linuxppc-dev@lists•ozlabs.org
Subject: [PATCH v2] powerpc: Track backing pages allocated by vmemmap_populate()
Date: Tue, 13 Apr 2010 14:16:23 +1000 [thread overview]
Message-ID: <201004131416.23941.markn@au1.ibm.com> (raw)
In-Reply-To: <201003261812.34095.markn@au1.ibm.com>
We need to keep track of the backing pages that get allocated by
vmemmap_populate() so that when we use kdump, the dump-capture kernel knows
where these pages are.
We use a linked list of structures that contain the physical address of the
backing page and corresponding virtual address to track the backing pages.
We can use an hlist to save space, because we never remove nodes.
vmemmap_populate() is called either at boot-time or on a memory hotplug
operation. We don't have to worry about the boot-time calls because they
will be inherently single-threaded, and for a memory hotplug operation
vmemmap_populate() is called through:
sparse_add_one_section()
|
V
kmalloc_section_memmap()
|
V
sparse_mem_map_populate()
|
V
vmemmap_populate()
and in sparse_add_one_section() we're protected by pgdat_resize_lock().
So, we don't need a spinlock to protect the vmemmap_list.
Signed-off-by: Mark Nelson <markn@au1•ibm.com>
---
changes since v1:
- use an hlist to save space in the structure
- remove the spinlock because it's not needed
arch/powerpc/include/asm/pgalloc-64.h | 7 +++++++
arch/powerpc/mm/init_64.c | 24 ++++++++++++++++++++++++
2 files changed, 31 insertions(+)
Index: upstream/arch/powerpc/include/asm/pgalloc-64.h
===================================================================
--- upstream.orig/arch/powerpc/include/asm/pgalloc-64.h
+++ upstream/arch/powerpc/include/asm/pgalloc-64.h
@@ -10,6 +10,13 @@
#include <linux/slab.h>
#include <linux/cpumask.h>
#include <linux/percpu.h>
+#include <linux/list.h>
+
+struct vmemmap_backing {
+ unsigned long phys;
+ unsigned long virt_addr;
+ struct hlist_node hlist;
+};
/*
* Functions that deal with pagetables that could be at any level of
Index: upstream/arch/powerpc/mm/init_64.c
===================================================================
--- upstream.orig/arch/powerpc/mm/init_64.c
+++ upstream/arch/powerpc/mm/init_64.c
@@ -43,6 +43,7 @@
#include <linux/lmb.h>
#include <linux/hugetlb.h>
#include <linux/slab.h>
+#include <linux/list.h>
#include <asm/pgalloc.h>
#include <asm/page.h>
@@ -252,6 +253,27 @@ static void __meminit vmemmap_create_map
}
#endif /* CONFIG_PPC_BOOK3E */
+HLIST_HEAD(vmemmap_list);
+
+static __meminit void vmemmap_list_populate(unsigned long phys,
+ unsigned long start,
+ int node)
+{
+ struct vmemmap_backing *vmem_back;
+
+ vmem_back = vmemmap_alloc_block(sizeof(struct vmemmap_backing), node);
+ if (unlikely(!vmem_back)) {
+ WARN_ON(1);
+ return;
+ }
+
+ vmem_back->phys = phys;
+ vmem_back->virt_addr = start;
+ INIT_HLIST_NODE(&vmem_back->hlist);
+
+ hlist_add_head(&vmem_back->hlist, &vmemmap_list);
+}
+
int __meminit vmemmap_populate(struct page *start_page,
unsigned long nr_pages, int node)
{
@@ -276,6 +298,8 @@ int __meminit vmemmap_populate(struct pa
if (!p)
return -ENOMEM;
+ vmemmap_list_populate(__pa(p), start, node);
+
pr_debug(" * %016lx..%016lx allocated at %p\n",
start, start + page_size, p);
next prev parent reply other threads:[~2010-04-13 4:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-26 7:12 [PATCH] powerpc: Track backing pages used allocated by vmemmap_populate() Mark Nelson
2010-04-13 4:16 ` Mark Nelson [this message]
2010-04-13 5:24 ` [PATCH v2] powerpc: Track backing pages " Michael Ellerman
2010-04-13 6:02 ` Mark Nelson
2010-04-13 11:16 ` Benjamin Herrenschmidt
2010-04-13 23:38 ` Mark Nelson
2010-04-22 2:21 ` [PATCH v3] " Mark Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201004131416.23941.markn@au1.ibm.com \
--to=markn@au1$(echo .)ibm.com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox